Opened 3 years ago

Closed 3 years ago

#24304 closed enhancement (fixed)

Make is_endomorphism_set be trivial for Endsets.

Reported by: tscrim Owned by:
Priority: major Milestone: sage-8.1
Component: categories Keywords: homset, endsets
Cc: jdemeyer Merged in:
Authors: Travis Scrimshaw Reviewers: Jeroen Demeyer
Report Upstream: N/A Work issues:
Branch: bee4fb9 (Commits, GitHub, GitLab) Commit: bee4fb98514fdbd6298b6474eaa20d13ab390b42
Dependencies: Stopgaps:

Status badges

Description

Right now, if a homset is in Endsets, the code in is_endomorphism_set still does the checks. However, by declaring in Endsets, this is guaranteed (otherwise it is a bug). We should not check anything and just return True.

Change History (5)

comment:1 Changed 3 years ago by tscrim

  • Branch set to public/categories/endsets_are_endsets-24304
  • Status changed from new to needs_review

comment:2 Changed 3 years ago by git

  • Commit set to 92f95cef93000042532acbf8d84e4bede8e699ea

Branch pushed to git repo; I updated commit sha1. New commits:

comment:3 Changed 3 years ago by git

  • Commit changed from 92f95cef93000042532acbf8d84e4bede8e699ea to bee4fb98514fdbd6298b6474eaa20d13ab390b42

Branch pushed to git repo; I updated commit sha1. New commits:

bee4fb9Making is_endomorphism_set use the category information.

comment:4 Changed 3 years ago by jdemeyer

  • Reviewers set to Jeroen Demeyer
  • Status changed from needs_review to positive_review

comment:5 Changed 3 years ago by vbraun

  • Branch changed from public/categories/endsets_are_endsets-24304 to bee4fb98514fdbd6298b6474eaa20d13ab390b42
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.