Opened 3 years ago
Closed 3 years ago
#24293 closed enhancement (fixed)
Use integer_check_long to implement Integer.__mod__
Reported by: | jdemeyer | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-8.1 |
Component: | basic arithmetic | Keywords: | |
Cc: | Merged in: | ||
Authors: | Jeroen Demeyer | Reviewers: | Travis Scrimshaw |
Report Upstream: | N/A | Work issues: | |
Branch: | b2715fb (Commits) | Commit: | b2715fbf36fe922f7103e25d552ca0422777372f |
Dependencies: | #24244 | Stopgaps: |
Description
Change History (5)
comment:1 Changed 3 years ago by
- Summary changed from Python 3 fixing for Integer.__mod__ to Use integer_check_long to implement Integer.__mod__
comment:2 Changed 3 years ago by
- Branch set to u/jdemeyer/python_3_fixing_for_integer___mod__
comment:3 Changed 3 years ago by
- Commit set to b2715fbf36fe922f7103e25d552ca0422777372f
- Status changed from new to needs_review
comment:4 Changed 3 years ago by
- Reviewers set to Travis Scrimshaw
- Status changed from needs_review to positive_review
LGTM.
comment:5 Changed 3 years ago by
- Branch changed from u/jdemeyer/python_3_fixing_for_integer___mod__ to b2715fbf36fe922f7103e25d552ca0422777372f
- Resolution set to fixed
- Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
New commits:
Move long.pxd to arith
Fake Integer interface
New functions integer_check_long() and integer_check_long_py()
Fix compiler warning
Use integer_check_long to implement Integer.__mod__