Opened 3 years ago

Last modified 3 years ago

#24263 new defect

MPolynomialRing_polydict not well tested

Reported by: embray Owned by:
Priority: major Milestone: sage-wishlist
Component: algebra Keywords:
Cc: Merged in:
Authors: Reviewers:
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

Something I hit upon in fixing some Python 3 issues is the sage.rings.polynomial.multi_polynomial_ring module and the MPolynomialRing_polydict class and its associated elements.

This is an example of where Sage's policy of "every function must have tests" does not actually guarantee good coverage, as few (if any) of the tests for this class explicitly use it. Instead many of the tests use the generic PolynomialRing constructor, which for many cases ends up returning Singular polynomial rings instead, so the relevant implementation does not end up being well tested (except perhaps indirectly in the cases of parent rings that are not handled by Singular).

It would be better if these tests used the class being tested explicitly, or perhaps if PolynomialRing had a better way to explicitly force the implementation to use (the existing implementation= keyword doesn't really do much currently except force Singular).

Change History (4)

comment:1 Changed 3 years ago by embray

  • Milestone changed from sage-8.1 to sage-8.2

comment:2 in reply to: ↑ description Changed 3 years ago by jdemeyer

Replying to embray:

perhaps if PolynomialRing had a better way to explicitly force the implementation to use (the existing implementation= keyword doesn't really do much currently except force Singular).

That should be easy: #24264.

comment:3 Changed 3 years ago by embray

  • Milestone changed from sage-8.2 to sage-8.3

comment:4 Changed 3 years ago by embray

  • Milestone changed from sage-8.3 to sage-wishlist
Note: See TracTickets for help on using tickets.