Opened 5 years ago

Closed 5 years ago

#24248 closed enhancement (fixed)

Fix isinstance(x, int) calls in element.pyx

Reported by: jdemeyer Owned by:
Priority: major Milestone: sage-8.1
Component: coercion Keywords:
Cc: Merged in:
Authors: Jeroen Demeyer Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 9c579c7 (Commits, GitHub, GitLab) Commit: 9c579c7ed1cf09f567c0452352b65d524ad66371
Dependencies: #24244 Stopgaps:

Status badges

Description


Change History (8)

comment:1 Changed 5 years ago by jdemeyer

  • Branch set to u/jdemeyer/ticket/24248

comment:2 Changed 5 years ago by git

  • Commit set to 46b6c25e146e51dca04e228b65625eae347c8045

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

​b1ea838New functions integer_check_long() and integer_check_long_py()
​46b6c25Fix isinstance(x, int) calls in element.pyx

comment:3 Changed 5 years ago by jdemeyer

  • Status changed from new to needs_review

comment:4 Changed 5 years ago by jdemeyer

  • Status changed from needs_review to needs_work

comment:5 Changed 5 years ago by git

  • Commit changed from 46b6c25e146e51dca04e228b65625eae347c8045 to 9c579c7ed1cf09f567c0452352b65d524ad66371

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

​bb114c9Fake Integer interface
​4d76bc1New functions integer_check_long() and integer_check_long_py()
​9c579c7Fix isinstance(x, int) calls in element.pyx

comment:6 Changed 5 years ago by jdemeyer

  • Status changed from needs_work to needs_review

comment:7 Changed 5 years ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

LGTM modulo #24244.

comment:8 Changed 5 years ago by vbraun

  • Branch changed from u/jdemeyer/ticket/24248 to 9c579c7ed1cf09f567c0452352b65d524ad66371
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.