Opened 5 years ago

Closed 5 years ago

#24242 closed enhancement (fixed)

Absolute import when importing string

Reported by: jdemeyer Owned by:
Priority: major Milestone: sage-8.1
Component: misc Keywords:
Cc: Merged in:
Authors: Jeroen Demeyer Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 55a76ce (Commits, GitHub, GitLab) Commit: 55a76ce77c3b9464d74ab5c2af4dac3cd8a5efcd
Dependencies: Stopgaps:

GitHub link to the corresponding issue

Description (last modified by jdemeyer)

A few Sage modules import the Python module string. Since this name is so generic, it might conflict with submodules inside Sage (this happened in #24222). So it's better to use from __future__ import absolute_import.

Change History (5)

comment:1 Changed 5 years ago by jdemeyer

Branch: u/jdemeyer/absolute_import_when_importing_string

comment:2 Changed 5 years ago by jdemeyer

Commit: 55a76ce77c3b9464d74ab5c2af4dac3cd8a5efcd
Description: modified (diff)
Status: newneeds_review

New commits:

55a76ceAdd absolute_import in a few places

comment:3 Changed 5 years ago by tscrim

Reviewers: Travis Scrimshaw
Status: needs_reviewpositive_review

LGTM.

comment:4 Changed 5 years ago by embray

I thought at some point we had agreed to just put from __future__ import absolute_import in every module. It is much better anyways than the old import semantics.

comment:5 Changed 5 years ago by vbraun

Branch: u/jdemeyer/absolute_import_when_importing_string55a76ce77c3b9464d74ab5c2af4dac3cd8a5efcd
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.