Opened 3 years ago

Closed 3 years ago

#24224 closed enhancement (fixed)

py3: some care for addition of keys()

Reported by: chapoton Owned by:
Priority: major Milestone: sage-8.1
Component: python3 Keywords:
Cc: embray, jdemeyer, tscrim, fbissey Merged in:
Authors: Frédéric Chapoton Reviewers: Jeroen Demeyer
Report Upstream: N/A Work issues:
Branch: b1b0d94 (Commits, GitHub, GitLab) Commit: b1b0d94c6e638865ed5b78e46e0ce7008872f3c3
Dependencies: Stopgaps:

Status badges


part of #15981

Change History (6)

comment:1 Changed 3 years ago by chapoton

  • Branch set to u/chapoton/24224
  • Cc embray jdemeyer tscrim fbissey added
  • Commit set to 6dbdbd3b3d6f08bbcf680d2a1bc8977eab6f9775

New commits:

6dbdbd3py3: some care for additions of keys()

comment:2 Changed 3 years ago by chapoton

  • Status changed from new to needs_review

comment:3 Changed 3 years ago by git

  • Commit changed from 6dbdbd3b3d6f08bbcf680d2a1bc8977eab6f9775 to b1b0d94c6e638865ed5b78e46e0ce7008872f3c3

Branch pushed to git repo; I updated commit sha1. New commits:

b1b0d94trac 24224 detail

comment:4 Changed 3 years ago by jdemeyer

  • Reviewers set to Jeroen Demeyer

Looks good. positive_review if patchbot is green.

comment:5 Changed 3 years ago by chapoton

  • Status changed from needs_review to positive_review

bot is morally green, setting to positive. Thanks

comment:6 Changed 3 years ago by vbraun

  • Branch changed from u/chapoton/24224 to b1b0d94c6e638865ed5b78e46e0ce7008872f3c3
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.