#24203 closed enhancement (fixed)

get rid of deprecated zero_element

Reported by: chapoton Owned by:
Priority: major Milestone: sage-8.1
Component: algebra Keywords:
Cc: tscrim, jdemeyer Merged in:
Authors: Frédéric Chapoton Reviewers: Vincent Delecroix
Report Upstream: N/A Work issues:
Branch: 6838f7b (Commits) Commit: 6838f7b3631eaf8b9610101ca2fb5a4a07e2d22a
Dependencies: Stopgaps:

Description

following #17694

Change History (9)

comment:1 Changed 20 months ago by chapoton

  • Branch set to u/chapoton/24203
  • Cc tscrim jdemeyer added
  • Commit set to e397350055d1d4a124f22676d6a5f89d1aebe35b
  • Status changed from new to needs_review

New commits:

e397350getting rid of the deprecated zero_element

comment:2 Changed 20 months ago by vdelecroix

  • Reviewers set to Vincent Delecroix
  • Status changed from needs_review to needs_work

The zero_element in pautomorphicform.py was not deprecated.

comment:3 Changed 20 months ago by git

  • Commit changed from e397350055d1d4a124f22676d6a5f89d1aebe35b to 854a9b0db3e490ab9a179dab7c61834462300b06

Branch pushed to git repo; I updated commit sha1. New commits:

854a9b0trac 24203 add new deprecation in pautomorphicform.py

comment:4 Changed 20 months ago by chapoton

  • Status changed from needs_work to needs_review

Thanks, Done

comment:5 Changed 20 months ago by vdelecroix

A possible doctest failure (reported by quasar)

sage -t --long src/doc/en/thematic_tutorials/coercion_and_categories.rst
**********************************************************************
File "src/doc/en/thematic_tutorials/coercion_and_categories.rst", line 466, in doc.en.thematic_tutorials.coercion_and_categories
Failed example:
    len([s for s in dir(MS1) if inspect.ismethod(getattr(MS1,s,None))])
Expected:
    79
Got:
    78
**********************************************************************
File "src/doc/en/thematic_tutorials/coercion_and_categories.rst", line 468, in doc.en.thematic_tutorials.coercion_and_categories
Failed example:
    len([s for s in dir(MS2) if inspect.ismethod(getattr(MS2,s,None))])
Expected:
    118
Got:
    117
**********************************************************************
1 item had failures:
   2 of 192 in doc.en.thematic_tutorials.coercion_and_categories
    [191 tests, 2 failures, 0.99 s]

comment:6 Changed 20 months ago by git

  • Commit changed from 854a9b0db3e490ab9a179dab7c61834462300b06 to 6838f7b3631eaf8b9610101ca2fb5a4a07e2d22a

Branch pushed to git repo; I updated commit sha1. New commits:

6838f7btrac 24203 fix doctest in coercion tutorial

comment:7 Changed 20 months ago by chapoton

Thanks, Done

comment:8 Changed 20 months ago by vdelecroix

  • Status changed from needs_review to positive_review

comment:9 Changed 19 months ago by vbraun

  • Branch changed from u/chapoton/24203 to 6838f7b3631eaf8b9610101ca2fb5a4a07e2d22a
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.