Opened 2 years ago

Closed 22 months ago

#24181 closed enhancement (fixed)

py3 some corrections for .values()[...] and .keys()[...]

Reported by: chapoton Owned by:
Priority: major Milestone: sage-8.1
Component: python3 Keywords:
Cc: tscrim, jdemeyer, jhpalmieri, aapitzsch, fbissey Merged in:
Authors: Frédéric Chapoton Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: b07c542 (Commits) Commit: b07c54270eae90d405c0a66d4869d59a2a336142
Dependencies: Stopgaps:

Description

part of #15981

Change History (7)

comment:1 Changed 2 years ago by chapoton

  • Branch set to u/chapoton/24181
  • Cc tscrim jdemeyer jhpalmieri aapitzsch fbissey added
  • Commit set to b707ce9348079d23ec3454ccfaf58828378c3c19
  • Status changed from new to needs_review

comment:2 Changed 2 years ago by fbissey

Did you forget to push your commits? The field branch says already merged in its tooltip.

comment:3 Changed 2 years ago by git

  • Commit changed from b707ce9348079d23ec3454ccfaf58828378c3c19 to b07c54270eae90d405c0a66d4869d59a2a336142

Branch pushed to git repo; I updated commit sha1. New commits:

b07c542py3: some care for keys and values

comment:4 Changed 2 years ago by chapoton

yes, sorry. Here it is.

comment:5 Changed 2 years ago by chapoton

bot is morally green

comment:6 Changed 2 years ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

LGTM.

comment:7 Changed 22 months ago by vbraun

  • Branch changed from u/chapoton/24181 to b07c54270eae90d405c0a66d4869d59a2a336142
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.