#24168 closed enhancement (fixed)
Upgrade Jupyter notebook
Reported by:  nthiery  Owned by:  

Priority:  major  Milestone:  sage8.1 
Component:  packages: standard  Keywords:  
Cc:  jdemeyer, saraedum  Merged in:  
Authors:  Nicolas M. Thiéry  Reviewers:  Jeroen Demeyer 
Report Upstream:  N/A  Work issues:  
Branch:  3f49dbc (Commits)  Commit:  
Dependencies:  #24198  Stopgaps: 
Description (last modified by )
Upstream tarballs:
 https://pypi.python.org/packages/78/2f/3d1383505943268f1f6f9e4fbf226bd36ba05bc6b1f6b748294d456d2b0c/notebook5.2.1.tar.gz#md5=ceb292c03c172947395d93b73a03e90e
 https://pypi.python.org/packages/b6/2d/2804f4de3a95583f65e5dcb4d7c8c7183124882323758996e867f47e72af/jupyter_core4.4.0.tar.gz#md5=7829fc07884ed98459e170f217e2a5ba
Change History (24)
comment:1 Changed 3 years ago by
comment:2 Changed 3 years ago by
Reference: #22432
comment:3 Changed 3 years ago by
Go for it..
comment:4 Changed 3 years ago by
I think there is some confusion here. jupyter version
returns the version of jupyter_core
which has a 4.4.0 release in the last 6 days.https://github.com/jupyter/jupyter_core/releases
Then there is the notebook, which is what you looked at with the pip command, the last release of that is indeed 5.2.1 https://github.com/jupyter/notebook/releases from 3 days ago. sage is at 4.4.1 (sageongentoo is at 5.0.0) so yes we could upgrade that.
Of course jupyter doesn't make it easy for you to figure the version of it components and what goes with what.
comment:5 followup: ↓ 6 Changed 3 years ago by
Also keep in mind that some pieces of Jupyter (I don't recall exactly which) are Python 3 only in their latest releases.
comment:6 in reply to: ↑ 5 Changed 3 years ago by
Replying to jdemeyer:
Also keep in mind that some pieces of Jupyter (I don't recall exactly which) are Python 3 only in their latest releases.
ipython6 is python3 only. However it looks like looks ipython5 still gets regular releases for python 2.7.
comment:7 Changed 3 years ago by
Thanks François for the clarification.
I am on it. I'll use the latest version suggested by pip; pip now knows not to suggest versions that are not compatible with Python's version.
Hopefuly no other dependency than jupyter_core needs to be updated!
comment:8 followup: ↓ 11 Changed 3 years ago by
Hmm, with the branch I am about to push, I get the following error upon creating a Sage notebook. Will investigate later ...
[I 11:31:18.215 NotebookApp] Creating new notebook in [E 11:31:19.356 NotebookApp] Failed to run command: [u'/usr/bin/sage', u'python', u'm', u'sage.repl.ipython_kernel', u'f', u'/run/user/1000/jupyter/kernelbf16b42618eb4f1b80ff4579ddecf42d.json'] PATH='/opt/sagegit/build/bin:/opt/sagegit/src/bin:/opt/sagegit/local/bin:/opt/miniconda3/bin:.:/home/nthiery/bin:/usr/games:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/local/games:/usr/bin/X11:/usr/etc' with kwargs: {'cwd': u'/home/nthiery/tmp', 'stdin': 1, 'preexec_fn': <function <lambda> at 0x7f9eef435c80>, 'stderr': None, 'stdout': None}
comment:9 Changed 3 years ago by
 Branch set to u/nthiery/upgrade_to_jupyter_5__
comment:10 Changed 3 years ago by
 Commit set to 20ebd7250bcaebe74a612724b3cfeea8621388d9
 Description modified (diff)
New commits:
20ebd72  24168: upgrade jupyter_core to 4.4.0 and notebook to 5.2.1

comment:11 in reply to: ↑ 8 ; followups: ↓ 14 ↓ 16 Changed 3 years ago by
Replying to nthiery:
Hmm, with the branch I am about to push, I get the following error upon creating a Sage notebook. Will investigate later ...
That was unrelated: I had an old kernelspec from Sage's debian package which was taking precedence and getting confused because in the mean time I had uninstalled this package.
Thus I guess it's a needs review.
I am not sure though what's the right way to test this?
comment:12 Changed 3 years ago by
 Status changed from new to needs_review
comment:13 Changed 3 years ago by
 Description modified (diff)
 Summary changed from Upgrade to Jupyter 5.* to Upgrade Jupyter notebook
comment:14 in reply to: ↑ 11 Changed 3 years ago by
Replying to nthiery:
I am not sure though what's the right way to test this?
Pretty much the only thing to do at this stage is to run ptestlong and then if that pass, wait for people complaining about change of behavior ^{_}
comment:15 Changed 3 years ago by
 Branch changed from u/nthiery/upgrade_to_jupyter_5__ to u/jdemeyer/upgrade_to_jupyter_5__
comment:16 in reply to: ↑ 11 Changed 3 years ago by
 Commit changed from 20ebd7250bcaebe74a612724b3cfeea8621388d9 to 367d753f3e0745bbb4f05412580e284d15923f9f
 Dependencies set to #24088
Replying to nthiery:
Replying to nthiery:
Hmm, with the branch I am about to push, I get the following error upon creating a Sage notebook. Will investigate later ...
That was unrelated: I had an old kernelspec from Sage's debian package which was taking precedence and getting confused because in the mean time I had uninstalled this package.
Thus I guess it's a needs review.
I am not sure though what's the right way to test this?
I'll test that it builds properly (I screwed up no less than 2 tickets this way in the latest beta). For that, I'm rebasing on #24088.
New commits:
c90fe7f  Add some dependencies for ipykernel

367d753  24168: upgrade jupyter_core to 4.4.0 and notebook to 5.2.1

comment:17 Changed 3 years ago by
Builds fine and passes make ptestlong
. So all that remains is to check that it actually works interactively.
comment:18 Changed 3 years ago by
 Commit changed from 367d753f3e0745bbb4f05412580e284d15923f9f to 3f49dbc544b4796e39a7ac55ce943886d7962a4c
comment:19 Changed 3 years ago by
 Dependencies changed from #24088 to #24198
comment:20 Changed 3 years ago by
 Reviewers set to Jeroen Demeyer
 Status changed from needs_review to positive_review
comment:21 followup: ↓ 22 Changed 3 years ago by
Any chance to get this into 8.1 or is it too late? That would ease deployment of mybinder thingies.
comment:22 in reply to: ↑ 21 Changed 3 years ago by
Replying to jpflori:
Any chance to get this into 8.1
1
Having a working Jupyter is too important to push this now.
comment:23 Changed 3 years ago by
 Branch changed from u/jdemeyer/upgrade_to_jupyter_5__ to 3f49dbc544b4796e39a7ac55ce943886d7962a4c
 Resolution set to fixed
 Status changed from positive_review to closed
comment:24 Changed 3 years ago by
 Commit 3f49dbc544b4796e39a7ac55ce943886d7962a4c deleted
See #24484 for a followup (nbconvert broken).
Beside manpower, is there any technical issue holding us from upgrading our package?
A small piece of motivation: binder (http://mybinder.org) requires jupyter 5.*; so if we upgrade, our docker image will be directly binder ready; currently in https://github.com/sagemath/sagebinderenv/blob/master/Dockerfile, I force a Jupyter upgrade.