Change History (24)

comment:1 Changed 2 years ago by nthiery

Beside manpower, is there any technical issue holding us from upgrading our package?

A small piece of motivation: binder (http://mybinder.org) requires jupyter 5.*; so if we upgrade, our docker image will be directly binder ready; currently in https://github.com/sagemath/sage-binder-env/blob/master/Dockerfile, I force a Jupyter upgrade.

comment:2 Changed 2 years ago by nthiery

Reference: #22432

comment:3 Changed 2 years ago by vbraun

Go for it..

comment:4 Changed 2 years ago by fbissey

I think there is some confusion here. jupyter --version returns the version of jupyter_core which has a 4.4.0 release in the last 6 days.https://github.com/jupyter/jupyter_core/releases

Then there is the notebook, which is what you looked at with the pip command, the last release of that is indeed 5.2.1 https://github.com/jupyter/notebook/releases from 3 days ago. sage is at 4.4.1 (sage-on-gentoo is at 5.0.0) so yes we could upgrade that.

Of course jupyter doesn't make it easy for you to figure the version of it components and what goes with what.

comment:5 follow-up: Changed 2 years ago by jdemeyer

Also keep in mind that some pieces of Jupyter (I don't recall exactly which) are Python 3 only in their latest releases.

comment:6 in reply to: ↑ 5 Changed 2 years ago by fbissey

Replying to jdemeyer:

Also keep in mind that some pieces of Jupyter (I don't recall exactly which) are Python 3 only in their latest releases.

ipython-6 is python3 only. However it looks like looks ipython-5 still gets regular releases for python 2.7.

comment:7 Changed 2 years ago by nthiery

Thanks François for the clarification.

I am on it. I'll use the latest version suggested by pip; pip now knows not to suggest versions that are not compatible with Python's version.

Hopefuly no other dependency than jupyter_core needs to be updated!

comment:8 follow-up: Changed 2 years ago by nthiery

Hmm, with the branch I am about to push, I get the following error upon creating a Sage notebook. Will investigate later ...

[I 11:31:18.215 NotebookApp] Creating new notebook in 
[E 11:31:19.356 NotebookApp] Failed to run command:
    [u'/usr/bin/sage', u'--python', u'-m', u'sage.repl.ipython_kernel', u'-f', u'/run/user/1000/jupyter/kernel-bf16b426-18eb-4f1b-80ff-4579ddecf42d.json']
        PATH='/opt/sage-git/build/bin:/opt/sage-git/src/bin:/opt/sage-git/local/bin:/opt/miniconda3/bin:.:/home/nthiery/bin:/usr/games:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/local/games:/usr/bin/X11:/usr/etc'
        with kwargs:
    {'cwd': u'/home/nthiery/tmp', 'stdin': -1, 'preexec_fn': <function <lambda> at 0x7f9eef435c80>, 'stderr': None, 'stdout': None}

comment:9 Changed 2 years ago by nthiery

  • Branch set to u/nthiery/upgrade_to_jupyter_5__

comment:10 Changed 2 years ago by nthiery

  • Commit set to 20ebd7250bcaebe74a612724b3cfeea8621388d9
  • Description modified (diff)

New commits:

20ebd7224168: upgrade jupyter_core to 4.4.0 and notebook to 5.2.1

comment:11 in reply to: ↑ 8 ; follow-ups: Changed 2 years ago by nthiery

Replying to nthiery:

Hmm, with the branch I am about to push, I get the following error upon creating a Sage notebook. Will investigate later ...

That was unrelated: I had an old kernelspec from Sage's debian package which was taking precedence and getting confused because in the mean time I had uninstalled this package.

Thus I guess it's a needs review.

I am not sure though what's the right way to test this?

comment:12 Changed 2 years ago by nthiery

  • Authors set to Nicolas M. Thiéry
  • Status changed from new to needs_review

comment:13 Changed 2 years ago by jdemeyer

  • Description modified (diff)
  • Summary changed from Upgrade to Jupyter 5.* to Upgrade Jupyter notebook

comment:14 in reply to: ↑ 11 Changed 2 years ago by fbissey

Replying to nthiery:

I am not sure though what's the right way to test this?

Pretty much the only thing to do at this stage is to run ptestlong and then if that pass, wait for people complaining about change of behavior _

comment:15 Changed 2 years ago by jdemeyer

  • Branch changed from u/nthiery/upgrade_to_jupyter_5__ to u/jdemeyer/upgrade_to_jupyter_5__

comment:16 in reply to: ↑ 11 Changed 2 years ago by jdemeyer

  • Commit changed from 20ebd7250bcaebe74a612724b3cfeea8621388d9 to 367d753f3e0745bbb4f05412580e284d15923f9f
  • Dependencies set to #24088

Replying to nthiery:

Replying to nthiery:

Hmm, with the branch I am about to push, I get the following error upon creating a Sage notebook. Will investigate later ...

That was unrelated: I had an old kernelspec from Sage's debian package which was taking precedence and getting confused because in the mean time I had uninstalled this package.

Thus I guess it's a needs review.

I am not sure though what's the right way to test this?

I'll test that it builds properly (I screwed up no less than 2 tickets this way in the latest beta). For that, I'm rebasing on #24088.


New commits:

c90fe7fAdd some dependencies for ipykernel
367d75324168: upgrade jupyter_core to 4.4.0 and notebook to 5.2.1

comment:17 Changed 2 years ago by jdemeyer

Builds fine and passes make ptestlong. So all that remains is to check that it actually works interactively.

comment:18 Changed 2 years ago by git

  • Commit changed from 367d753f3e0745bbb4f05412580e284d15923f9f to 3f49dbc544b4796e39a7ac55ce943886d7962a4c

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

f8eef4eUse correct format for nbserver_extensions
3f49dbc24168: upgrade jupyter_core to 4.4.0 and notebook to 5.2.1

comment:19 Changed 2 years ago by jdemeyer

  • Dependencies changed from #24088 to #24198

New commits:

f8eef4eUse correct format for nbserver_extensions
3f49dbc24168: upgrade jupyter_core to 4.4.0 and notebook to 5.2.1

comment:20 Changed 2 years ago by jdemeyer

  • Reviewers set to Jeroen Demeyer
  • Status changed from needs_review to positive_review

comment:21 follow-up: Changed 2 years ago by jpflori

Any chance to get this into 8.1 or is it too late? That would ease deployment of mybinder thingies.

comment:22 in reply to: ↑ 21 Changed 2 years ago by jdemeyer

Replying to jpflori:

Any chance to get this into 8.1

-1

Having a working Jupyter is too important to push this now.

comment:23 Changed 2 years ago by vbraun

  • Branch changed from u/jdemeyer/upgrade_to_jupyter_5__ to 3f49dbc544b4796e39a7ac55ce943886d7962a4c
  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:24 Changed 2 years ago by egourgoulhon

  • Commit 3f49dbc544b4796e39a7ac55ce943886d7962a4c deleted

See #24484 for a follow-up (nbconvert broken).

Note: See TracTickets for help on using tickets.