Upgrade Jupyter notebook

[nthiery]

Upstream tarballs:

1. ​https://pypi.python.org/packages/78/2f/3d1383505943268f1f6f9e4fbf226bd36ba05bc6b1f6b748294d456d2b0c/notebook-5.2.1.tar.gz#md5=ceb292c03c172947395d93b73a03e90e
2. ​https://pypi.python.org/packages/b6/2d/2804f4de3a95583f65e5dcb4d7c8c7183124882323758996e867f47e72af/jupyter_core-4.4.0.tar.gz#md5=7829fc07884ed98459e170f217e2a5ba

[nthiery]

Beside manpower, is there any technical issue holding us from upgrading our package?

A small piece of motivation: binder (​http://mybinder.org) requires jupyter 5.*; so if we upgrade, our docker image will be directly binder ready; currently in ​https://github.com/sagemath/sage-binder-env/blob/master/Dockerfile, I force a Jupyter upgrade.

[nthiery]

Reference: #22432

[vbraun]

Go for it..

[fbissey]

I think there is some confusion here. jupyter --version returns the version of jupyter_core which has a 4.4.0 release in the last 6 days.​https://github.com/jupyter/jupyter_core/releases

Then there is the notebook, which is what you looked at with the pip command, the last release of that is indeed 5.2.1 ​https://github.com/jupyter/notebook/releases from 3 days ago. sage is at 4.4.1 (sage-on-gentoo is at 5.0.0) so yes we could upgrade that.

Of course jupyter doesn't make it easy for you to figure the version of it components and what goes with what.

[jdemeyer]

Also keep in mind that some pieces of Jupyter (I don't recall exactly which) are Python 3 only in their latest releases.

[fbissey]

Replying to jdemeyer:

Also keep in mind that some pieces of Jupyter (I don't recall exactly which) are Python 3 only in their latest releases.

ipython-6 is python3 only. However it looks like looks ipython-5 still gets regular releases for python 2.7.

[nthiery]

Thanks François for the clarification.

I am on it. I'll use the latest version suggested by pip; pip now knows not to suggest versions that are not compatible with Python's version.

Hopefuly no other dependency than jupyter_core needs to be updated!

[nthiery]

Hmm, with the branch I am about to push, I get the following error upon creating a Sage notebook. Will investigate later ...

[I 11:31:18.215 NotebookApp] Creating new notebook in 
[E 11:31:19.356 NotebookApp] Failed to run command:
    [u'/usr/bin/sage', u'--python', u'-m', u'sage.repl.ipython_kernel', u'-f', u'/run/user/1000/jupyter/kernel-bf16b426-18eb-4f1b-80ff-4579ddecf42d.json']
        PATH='/opt/sage-git/build/bin:/opt/sage-git/src/bin:/opt/sage-git/local/bin:/opt/miniconda3/bin:.:/home/nthiery/bin:/usr/games:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/local/games:/usr/bin/X11:/usr/etc'
        with kwargs:
    {'cwd': u'/home/nthiery/tmp', 'stdin': -1, 'preexec_fn': <function <lambda> at 0x7f9eef435c80>, 'stderr': None, 'stdout': None}

[nthiery]

New commits:

​20ebd72

24168: upgrade jupyter_core to 4.4.0 and notebook to 5.2.1

[nthiery]

Replying to nthiery:

Hmm, with the branch I am about to push, I get the following error upon creating a Sage notebook. Will investigate later ...

That was unrelated: I had an old kernelspec from Sage's debian package which was taking precedence and getting confused because in the mean time I had uninstalled this package.

Thus I guess it's a needs review.

I am not sure though what's the right way to test this?

[fbissey]

Replying to nthiery:

I am not sure though what's the right way to test this?

Pretty much the only thing to do at this stage is to run ptestlong and then if that pass, wait for people complaining about change of behavior ^_

[jdemeyer]

Replying to nthiery:

Replying to nthiery:

Hmm, with the branch I am about to push, I get the following error upon creating a Sage notebook. Will investigate later ...

That was unrelated: I had an old kernelspec from Sage's debian package which was taking precedence and getting confused because in the mean time I had uninstalled this package.

Thus I guess it's a needs review.

I am not sure though what's the right way to test this?

I'll test that it builds properly (I screwed up no less than 2 tickets this way in the latest beta). For that, I'm rebasing on #24088.

---

New commits:

​c90fe7f	Add some dependencies for ipykernel
​367d753	24168: upgrade jupyter_core to 4.4.0 and notebook to 5.2.1

[jdemeyer]

Builds fine and passes make ptestlong. So all that remains is to check that it actually works interactively.

[git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

​f8eef4e	Use correct format for nbserver_extensions
​3f49dbc	24168: upgrade jupyter_core to 4.4.0 and notebook to 5.2.1

[jdemeyer]

New commits:

​f8eef4e	Use correct format for nbserver_extensions
​3f49dbc	24168: upgrade jupyter_core to 4.4.0 and notebook to 5.2.1

[jpflori]

Any chance to get this into 8.1 or is it too late? That would ease deployment of mybinder thingies.

[jdemeyer]

Replying to jpflori:

Any chance to get this into 8.1

-1

Having a working Jupyter is too important to push this now.

[egourgoulhon]

See #24484 for a follow-up (nbconvert broken).