Opened 5 years ago

Closed 5 years ago

#24156 closed enhancement (fixed)

Construction of RealSet from inequality

Reported by: Ralf Stephan Owned by:
Priority: major Milestone: sage-8.2
Component: basic arithmetic Keywords:
Cc: Merged in:
Authors: Ralf Stephan Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 12b6464 (Commits, GitHub, GitLab) Commit: 12b6464f31fa3d66964c63ee4e123b7e4cfeaf67
Dependencies: Stopgaps:

Status badges

Description

Make this possible:

sage: RealSet(x>0)
(0, +oo)

at the moment:
...
ValueError: x > 0 does not determine real interval

Change History (9)

comment:1 Changed 5 years ago by Ralf Stephan

Component: miscbasic arithmetic

comment:2 Changed 5 years ago by Ralf Stephan

Branch: u/rws/construction_of_realset_from_inequality

comment:3 Changed 5 years ago by Ralf Stephan

Authors: Ralf Stephan
Commit: 51d309142abc07e2c4054161c37726afd86a0141
Status: newneeds_review

New commits:

51d309124156: Construction of RealSet from inequality

comment:4 Changed 5 years ago by Travis Scrimshaw

Reviewers: Travis Scrimshaw

Can you add tests for x <= oo, x >= oo, and x >= -oo to check these (essentially corner) cases? Otherwise LGTM.

comment:5 Changed 5 years ago by Ralf Stephan

Status: needs_reviewneeds_work

I somehow introduced this, needs to be fixed:

sage: RealSet(-oo,oo)
(-oo, +Infinity)
sage: RealSet(0,oo)
(0, +oo)

comment:6 Changed 5 years ago by git

Commit: 51d309142abc07e2c4054161c37726afd86a014112b6464f31fa3d66964c63ee4e123b7e4cfeaf67

Branch pushed to git repo; I updated commit sha1. New commits:

12b646424156: fix Infinity output; more oo doctests

comment:7 Changed 5 years ago by Ralf Stephan

Status: needs_workneeds_review

comment:8 Changed 5 years ago by Travis Scrimshaw

Status: needs_reviewpositive_review

LGTM. Thanks.

comment:9 Changed 5 years ago by Volker Braun

Branch: u/rws/construction_of_realset_from_inequality12b6464f31fa3d66964c63ee4e123b7e4cfeaf67
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.