Opened 5 years ago
Closed 5 years ago
#24154 closed defect (fixed)
Fix equation handling of Polyhedron.to_linear_program() and thus integral_points_count(preprocess=True)
Reported by: | mkoeppe | Owned by: | |
---|---|---|---|
Priority: | critical | Milestone: | sage-8.1 |
Component: | geometry | Keywords: | |
Cc: | SimonKing, vdelecroix, jipilab | Merged in: | |
Authors: | Matthias Koeppe | Reviewers: | Dima Pasechnik |
Report Upstream: | N/A | Work issues: | |
Branch: | 6ad4bf7 (Commits, GitHub, GitLab) | Commit: | 6ad4bf7868923b9382bce80b4372e9ad014d0cd3 |
Dependencies: | Stopgaps: |
Description (last modified by )
As reported in https://groups.google.com/d/msg/sage-devel/TuF0CidR-JI/8-zpcu-MCgAJ, the preprocessing code in integral_points_count
sometimes fails. This is ultimately because Polyhedron.to_linear_program
does not handle equations correctly.
sage: P = Polyhedron(vertices=[[19]]) sage: P.to_linear_program().show() Maximization: Constraints: constraint_0: -19 <= x_0 <= -19 Variables: x_0 is a continuous variable (min=-oo, max=+oo) sage: P.to_linear_program().polyhedron().vertices_list() [[-19]]
Change History (6)
comment:1 Changed 5 years ago by
- Description modified (diff)
comment:2 Changed 5 years ago by
- Component changed from PLEASE CHANGE to geometry
comment:3 Changed 5 years ago by
- Branch set to u/mkoeppe/fix_equation_handling_polyhedron_to_linear_program
comment:4 Changed 5 years ago by
- Commit set to 6ad4bf7868923b9382bce80b4372e9ad014d0cd3
- Status changed from new to needs_review
comment:5 Changed 5 years ago by
- Reviewers set to Dima Pasechnik
- Status changed from needs_review to positive_review
OK, makes sense.
comment:6 Changed 5 years ago by
- Branch changed from u/mkoeppe/fix_equation_handling_polyhedron_to_linear_program to 6ad4bf7868923b9382bce80b4372e9ad014d0cd3
- Resolution set to fixed
- Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
New commits:
24154: Fix equation handling of Polyhedron.to_linear_program()