Opened 3 years ago

Closed 3 years ago

#24136 closed enhancement (duplicate)

py3: fix pickling of integers

Reported by: chapoton Owned by: embray
Priority: major Milestone: sage-duplicate/invalid/wontfix
Component: python3 Keywords: unicode
Cc: jdemeyer, embray Merged in:
Authors: Reviewers:
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

namely fix make_integer and _reduce_set in integer.pyx

in python3-build sage:

sage: make_integer(b'-29')
-73
sage: make_integer(73.str(32))
Traceback (most recent call last)
<ipython-input-33-d2fb0cccba3c> in <module>()
----> 1 make_integer(Integer(73).str(Integer(32)))

/home/chapoton/sage3/src/sage/rings/integer.pyx in sage.rings.integer.make_integer (build/cythonized/sage/rings/integer.c:43646)()

/home/chapoton/sage3/src/sage/rings/integer.pyx in sage.rings.integer.Integer._reduce_set (build/cythonized/sage/rings/integer.c:6857)()

TypeError: expected bytes, str found

Change History (10)

comment:1 Changed 3 years ago by chapoton

  • Keywords unicode added

comment:2 Changed 3 years ago by chapoton

  • Cc embray added

This is closely related to #23812

comment:3 Changed 3 years ago by embray

  • Owner changed from (none) to embray

Cool, I'll address this. I'm going to post a big ticket full of string fixes soon.

comment:4 Changed 3 years ago by embray

  • Milestone changed from sage-8.1 to sage-8.2

comment:5 Changed 3 years ago by chapoton

  • Milestone changed from sage-8.2 to sage-duplicate/invalid/wontfix
  • Status changed from new to needs_review

Has this been adressed elsehwere, Erik ?

comment:6 Changed 3 years ago by embray

  • Milestone changed from sage-duplicate/invalid/wontfix to sage-8.2
  • Status changed from needs_review to needs_work

I actually haven't. Let's keep this ticket open and I'll use it to place string-related fixes for sage.rings.integer.

comment:7 Changed 3 years ago by embray

This was a small change, so I folded into #24223. Once that's closed this can be closed as fixed.

comment:8 Changed 3 years ago by chapoton

  • Milestone changed from sage-8.2 to sage-duplicate/invalid/wontfix

so please close this one now

comment:9 Changed 3 years ago by chapoton

  • Status changed from needs_work to needs_review

comment:10 Changed 3 years ago by jdemeyer

  • Resolution set to duplicate
  • Status changed from needs_review to closed
Note: See TracTickets for help on using tickets.