Opened 3 years ago

Last modified 3 years ago

#24135 closed enhancement

Clean up in coerce_dict — at Version 6

Reported by: jdemeyer Owned by:
Priority: major Milestone: sage-8.1
Component: coercion Keywords:
Cc: SimonKing, nbruin, tscrim, chapoton Merged in:
Authors: Jeroen Demeyer Reviewers:
Report Upstream: N/A Work issues:
Branch: u/jdemeyer/clean_up_in_coerce_dict (Commits, GitHub, GitLab) Commit: 5abd7b8d5f12fd2d1b516d17feed7407c87381e1
Dependencies: Stopgaps:

Status badges

Description (last modified by jdemeyer)

  1. Deprecate various arguments which should have been deprecated in #15367.
  1. Use a tuple instead of a list to throw away. This is very slightly faster.
  1. Use safe memory functions from cysignals instead of PyMem functions.
  1. Split __init__ into __cinit__ and __init__.
  1. Rename the iteritems() method to items().
  1. Introduce a new inline function valid(ptr) to replace the very common ptr != NULL and ptr != dummy
  1. Change type of key_id from void* to PyObject*. This avoids a lot of casts.
  1. Generic code cleanup.

Change History (6)

comment:1 Changed 3 years ago by jdemeyer

  • Description modified (diff)

comment:2 Changed 3 years ago by jdemeyer

  • Branch set to u/jdemeyer/clean_up_in_coerce_dict

comment:3 Changed 3 years ago by tscrim

  • Cc tscrim added
  • Commit set to 5abd7b8d5f12fd2d1b516d17feed7407c87381e1

New commits:

​5abd7b8Clean up in coerce_dict

comment:4 Changed 3 years ago by jdemeyer

  • Description modified (diff)

comment:5 Changed 3 years ago by jdemeyer

  • Description modified (diff)

comment:6 Changed 3 years ago by jdemeyer

  • Description modified (diff)
Note: See TracTickets for help on using tickets.