Opened 3 years ago
Last modified 3 years ago
#24135 closed enhancement
Clean up in coerce_dict — at Version 6
Reported by: | jdemeyer | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-8.1 |
Component: | coercion | Keywords: | |
Cc: | SimonKing, nbruin, tscrim, chapoton | Merged in: | |
Authors: | Jeroen Demeyer | Reviewers: | |
Report Upstream: | N/A | Work issues: | |
Branch: | u/jdemeyer/clean_up_in_coerce_dict (Commits, GitHub, GitLab) | Commit: | 5abd7b8d5f12fd2d1b516d17feed7407c87381e1 |
Dependencies: | Stopgaps: |
Description (last modified by )
- Deprecate various arguments which should have been deprecated in #15367.
- Use a tuple instead of a list to throw away. This is very slightly faster.
- Use safe memory functions from cysignals instead of
PyMem
functions.
- Split
__init__
into__cinit__
and__init__
.
- Rename the
iteritems()
method toitems()
.
- Introduce a new inline function
valid(ptr)
to replace the very commonptr != NULL and ptr != dummy
- Change type of
key_id
fromvoid*
toPyObject*
. This avoids a lot of casts.
- Generic code cleanup.
Change History (6)
comment:1 Changed 3 years ago by
- Description modified (diff)
comment:2 Changed 3 years ago by
- Branch set to u/jdemeyer/clean_up_in_coerce_dict
comment:3 Changed 3 years ago by
- Cc tscrim added
- Commit set to 5abd7b8d5f12fd2d1b516d17feed7407c87381e1
comment:4 Changed 3 years ago by
- Description modified (diff)
comment:5 Changed 3 years ago by
- Description modified (diff)
comment:6 Changed 3 years ago by
- Description modified (diff)
Note: See
TracTickets for help on using
tickets.
New commits:
Clean up in coerce_dict