Opened 3 years ago
Closed 3 years ago
#24134 closed defect (fixed)
Fix iteritems() in Cython code
Reported by: | jdemeyer | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-8.1 |
Component: | python3 | Keywords: | |
Cc: | chapoton | Merged in: | |
Authors: | Jeroen Demeyer | Reviewers: | Frédéric Chapoton, Travis Scrimshaw |
Report Upstream: | N/A | Work issues: | |
Branch: | ae7a93a (Commits, GitHub, GitLab) | Commit: | ae7a93a945e2f77a487ed701a348f221e7f05ac5 |
Dependencies: | Stopgaps: |
Description
In a few cases, obj.iteritems()
does not get special cased by Cython if Cython is not aware that obj
is a dict.
Change History (10)
comment:1 Changed 3 years ago by
- Branch set to u/jdemeyer/fix_iteritems___in_cython_code
comment:2 follow-up: ↓ 3 Changed 3 years ago by
- Commit set to 57f86b3a44dd32757bf41308c78614e908a82a33
comment:3 in reply to: ↑ 2 Changed 3 years ago by
- Status changed from new to needs_review
comment:4 Changed 3 years ago by
one failing doctest, see patchbot reports
comment:5 Changed 3 years ago by
- Status changed from needs_review to needs_work
comment:6 Changed 3 years ago by
- Commit changed from 57f86b3a44dd32757bf41308c78614e908a82a33 to ae7a93a945e2f77a487ed701a348f221e7f05ac5
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
ae7a93a | Fix iteritems() calls in Cython code
|
comment:7 Changed 3 years ago by
- Status changed from needs_work to needs_review
comment:8 Changed 3 years ago by
Patchbot is green...
comment:9 Changed 3 years ago by
- Reviewers set to Frédéric Chapoton, Travis Scrimshaw
- Status changed from needs_review to positive_review
LGTM.
comment:10 Changed 3 years ago by
- Branch changed from u/jdemeyer/fix_iteritems___in_cython_code to ae7a93a945e2f77a487ed701a348f221e7f05ac5
- Resolution set to fixed
- Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
What about itervalues and iterkeys ?
New commits:
Fix iteritems() calls in Cython code