Opened 2 years ago

Closed 22 months ago

#24115 closed enhancement (fixed)

Remove ContinuedFractionField

Reported by: jdemeyer Owned by:
Priority: major Milestone: sage-8.1
Component: basic arithmetic Keywords:
Cc: Merged in:
Authors: Jeroen Demeyer Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 3d47c2f (Commits) Commit: 3d47c2fb31d1a5110776cf50dac45ef3ae3594d2
Dependencies: #24337 Stopgaps:

Description

Deprecated in #20012

Change History (9)

comment:1 Changed 2 years ago by jdemeyer

  • Branch set to u/jdemeyer/remove_continuedfractionfield

comment:2 Changed 2 years ago by chapoton

  • Commit set to dff604251b9a64e2d3efe3827dfe5161304174bc

needs review ?


New commits:

dff6042Remove ContinuedFractionField

comment:3 follow-up: Changed 2 years ago by roed

Wait, so if we're getting rid of ContinuedFractionField, what is the right way to get continued fractions for real numbers?

comment:4 in reply to: ↑ 3 Changed 2 years ago by jdemeyer

Replying to roed:

Wait, so if we're getting rid of ContinuedFractionField, what is the right way to get continued fractions for real numbers?

sage: continued_fraction(pi)
[3; 7, 15, 1, 292, 1, 1, 1, 2, 1, 3, 1, 14, 2, 1, 1, 2, 2, 2, 2, ...]

comment:5 Changed 2 years ago by roed

Okay. I think it would be useful to have continued_fraction methods on real numbers and elements of the symbolic ring, but that can be for another ticket.

comment:6 Changed 23 months ago by jdemeyer

  • Dependencies set to #24337
  • Status changed from new to needs_review

comment:7 Changed 23 months ago by git

  • Commit changed from dff604251b9a64e2d3efe3827dfe5161304174bc to 3d47c2fb31d1a5110776cf50dac45ef3ae3594d2

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

3d47c2fRemove ContinuedFractionField

comment:8 Changed 23 months ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

LGTM (the patchbot failure should be handled by #24337).

comment:9 Changed 22 months ago by vbraun

  • Branch changed from u/jdemeyer/remove_continuedfractionfield to 3d47c2fb31d1a5110776cf50dac45ef3ae3594d2
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.