Opened 4 years ago

Closed 4 years ago

#24111 closed enhancement (fixed)

Upgrade to Cython 0.28.1

Reported by: jdemeyer Owned by:
Priority: major Milestone: sage-8.2
Component: packages: standard Keywords:
Cc: fbissey, embray Merged in:
Authors: Jeroen Demeyer Reviewers: Ralf Stephan
Report Upstream: N/A Work issues:
Branch: e9efe88 (Commits, GitHub, GitLab) Commit: e9efe88316733178b9330b21eee2c207f01132fd
Dependencies: #24915, #24916 Stopgaps:

Status badges

Change History (20)

comment:1 Changed 4 years ago by jdemeyer

  • Summary changed from Use Cython late import patch to Use Cython late include patch

comment:2 Changed 4 years ago by jdemeyer

  • Branch set to u/jdemeyer/ticket/24111

comment:3 Changed 4 years ago by jdemeyer

  • Commit set to 64854cbfe5f09087371cf95da898056693840e23
  • Dependencies changed from #24110 to #24183

New commits:

64854cbAdd Cython late include patch

comment:4 Changed 4 years ago by git

  • Commit changed from 64854cbfe5f09087371cf95da898056693840e23 to c0b3a81977568d69aef371a6c4db4cafa0a467c8

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

c331d9bGenerate eclib includes in a predictable order
c0b3a81Add Cython late include patch

comment:5 Changed 4 years ago by jdemeyer

  • Dependencies #24183 deleted
  • Description modified (diff)
  • Milestone changed from sage-8.1 to sage-8.2
  • Summary changed from Use Cython late include patch to Upgrade to Cython 0.28

comment:6 Changed 4 years ago by git

  • Commit changed from c0b3a81977568d69aef371a6c4db4cafa0a467c8 to 05e018f348100cf1c4352edaeae3dc01db01f75a

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

0cee6c2Remove a few duplicate declarations
afedfc3Use GCD() from NTL instead of copy/pasting
05e2774Fix __richcmp__ calls with reversed operands
fefb7beUpgrade to Cython 0.28
05e018fUse late includes

comment:7 Changed 4 years ago by jdemeyer

  • Dependencies set to #24915, #24916

comment:8 Changed 4 years ago by fbissey

  • Cc fbissey added

comment:9 Changed 4 years ago by git

  • Commit changed from 05e018f348100cf1c4352edaeae3dc01db01f75a to 0fa083c330adeeb0f8a8f72d6f30da1f38ba81de

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

9ff83c7Remove a few duplicate declarations
d2ca9c7Use GCD() from NTL instead of copy/pasting
6ec2adcFix __richcmp__ calls with reversed operands
84d7ea1Upgrade to Cython 0.28
0fa083cUse late includes

comment:10 Changed 4 years ago by jdemeyer

  • Description modified (diff)

comment:11 Changed 4 years ago by git

  • Commit changed from 0fa083c330adeeb0f8a8f72d6f30da1f38ba81de to 87e202bfafeac8146c69bf5b1c58eddf2f9fbd2f

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

2bc0487Remove a few duplicate declarations
fb6115dUse GCD() from NTL instead of copy/pasting
f6d4851Fix __richcmp__ calls with reversed operands
1865758Upgrade to Cython 0.28
87e202bUse late includes

comment:12 Changed 4 years ago by jdemeyer

  • Description modified (diff)

comment:13 Changed 4 years ago by git

  • Commit changed from 87e202bfafeac8146c69bf5b1c58eddf2f9fbd2f to a77373e93056ffbe4df1c85dcc9fdcad8e674b69

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

9ff83c7Remove a few duplicate declarations
d2ca9c7Use GCD() from NTL instead of copy/pasting
ef5813aFix __richcmp__ calls with reversed operands
18cad54Merge commit 'd2ca9c712e9a2342498e15b4f2a2c4d69c67d6b6'; commit 'ef5813a9d2f72e91cde914e243981f5354196ea8' into HEAD
4483a72Upgrade to Cython 0.28
a77373eUse late includes

comment:14 Changed 4 years ago by jdemeyer

  • Cc embray added
  • Status changed from new to needs_review

comment:15 Changed 4 years ago by jdemeyer

  • Description modified (diff)
  • Status changed from needs_review to needs_work
  • Summary changed from Upgrade to Cython 0.28 to Upgrade to Cython 0.28.1

comment:16 Changed 4 years ago by git

  • Commit changed from a77373e93056ffbe4df1c85dcc9fdcad8e674b69 to e9efe88316733178b9330b21eee2c207f01132fd

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

1b2c34cUpgrade to Cython 0.28.1
e9efe88Use late includes

comment:17 Changed 4 years ago by jdemeyer

  • Status changed from needs_work to needs_review

comment:18 Changed 4 years ago by rws

Looks good, testing now.

comment:19 Changed 4 years ago by rws

  • Reviewers set to Ralf Stephan
  • Status changed from needs_review to positive_review

comment:20 Changed 4 years ago by vbraun

  • Branch changed from u/jdemeyer/ticket/24111 to e9efe88316733178b9330b21eee2c207f01132fd
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.