Opened 5 years ago

Closed 5 years ago

#24109 closed enhancement (fixed)

Always enable debug.bad_parent_warnings

Reported by: Jeroen Demeyer Owned by:
Priority: major Milestone: sage-8.1
Component: misc Keywords:
Cc: Merged in:
Authors: Jeroen Demeyer Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 3cf11a9 (Commits, GitHub, GitLab) Commit: 3cf11a9f61f1240c5e0747f0d47e71a1c967752b
Dependencies: Stopgaps:

Status badges

Description (last modified by Jeroen Demeyer)

It seems that none of the bad_parent_warnings warnings is triggered in the Sage library, so we can make this check unconditional. When the check fails, a deprecation warning is raised.

This fixes #21353.

Change History (11)

comment:1 Changed 5 years ago by Jeroen Demeyer

Branch: u/jdemeyer/always_enable_debug_bad_parent_warnings

comment:2 Changed 5 years ago by Jeroen Demeyer

Commit: bff915039e7c47d5a305e5b8586c6e98c2e749c5
Description: modified (diff)
Status: newneeds_review

New commits:

bff9150Always enable bad_parent_warnings

comment:3 Changed 5 years ago by git

Commit: bff915039e7c47d5a305e5b8586c6e98c2e749c5ae9a00d61845b2d5dce6fcbaf92bafffd001c46e

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

ae9a00dAlways enable bad_parent_warnings

comment:4 Changed 5 years ago by Jeroen Demeyer

Description: modified (diff)

comment:5 Changed 5 years ago by Jeroen Demeyer

Description: modified (diff)

comment:6 Changed 5 years ago by Travis Scrimshaw

Do we want to just ignore all invalid keywords in Parent or will we want to make it a hard error after the deprecation period? I'm in favor of the latter, which means the deprecation message should not have the "and ignored" part.

comment:7 in reply to:  6 Changed 5 years ago by Jeroen Demeyer

Replying to tscrim:

Do we want to just ignore all invalid keywords in Parent or will we want to make it a hard error after the deprecation period?

An error of course.

which means the deprecation message should not have the "and ignored" part.

I meant to say that the option is currently ignored. This is to contrast with the typical case for deprecation, where an option is still supported but deprecated. I can improve the wording if you wish.

comment:8 Changed 5 years ago by git

Commit: ae9a00d61845b2d5dce6fcbaf92bafffd001c46e3cf11a9f61f1240c5e0747f0d47e71a1c967752b

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

3cf11a9Always enable bad_parent_warnings

comment:9 Changed 5 years ago by Jeroen Demeyer

I made the deprecation messages more verbose.

comment:10 Changed 5 years ago by Travis Scrimshaw

Reviewers: Travis Scrimshaw
Status: needs_reviewpositive_review

Thank you. Before it just felt like the message was saying after the deprecation it would have been silently ignored.

comment:11 Changed 5 years ago by Volker Braun

Branch: u/jdemeyer/always_enable_debug_bad_parent_warnings3cf11a9f61f1240c5e0747f0d47e71a1c967752b
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.