#24096 closed enhancement (fixed)
Deprecate sage.matrix.matrix
Reported by:  jdemeyer  Owned by:  

Priority:  major  Milestone:  sage8.1 
Component:  linear algebra  Keywords:  
Cc:  Merged in:  
Authors:  Jeroen Demeyer  Reviewers:  Travis Scrimshaw 
Report Upstream:  N/A  Work issues:  
Branch:  c970ec5 (Commits, GitHub, GitLab)  Commit:  
Dependencies:  Stopgaps: 
Description (last modified by )
There is the base matrix class in structure.element
and a corresponding is_Matrix
function. Moreover, the matrix.matrix.Matrix
class implements no functionality.
Change History (18)
comment:1 Changed 5 years ago by
 Branch set to u/jdemeyer/deprecate_sage_matrix_matrix
comment:2 Changed 5 years ago by
 Commit set to 8d59a704ec51c972dcaf3f4adc72396e6e5f1857
 Status changed from new to needs_review
comment:3 Changed 5 years ago by
 Description modified (diff)
 Reviewers set to Travis Scrimshaw
 Status changed from needs_review to positive_review
I added my understanding of th reasoning to the description. LGTM.
comment:5 Changed 5 years ago by
comment:6 followup: ↓ 11 Changed 5 years ago by
In matrix/special.py
, there is also from .matrix import is_Matrix
. Should that also be replaced?
comment:7 Changed 5 years ago by
rc is out... I wait for this ticket to look at #23706
comment:8 Changed 5 years ago by
 Commit changed from 8d59a704ec51c972dcaf3f4adc72396e6e5f1857 to a8ea3bc77dcd1f38b3f48874255298386ff8ceaa
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
a8ea3bc  Deprecate sage.matrix.matrix

comment:9 Changed 5 years ago by
 Status changed from needs_work to needs_review
comment:10 Changed 5 years ago by
 Commit changed from a8ea3bc77dcd1f38b3f48874255298386ff8ceaa to cae563107157ae968e1e2cf88056ea594f1b7c74
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
cae5631  Deprecate sage.matrix.matrix

comment:11 in reply to: ↑ 6 Changed 5 years ago by
Replying to tscrim:
In
matrix/special.py
, there is alsofrom .matrix import is_Matrix
. Should that also be replaced?
Sure. Although I don't understand why this wasn't causing doctest failures...
comment:12 Changed 5 years ago by
 Commit changed from cae563107157ae968e1e2cf88056ea594f1b7c74 to c970ec5871603a8ec8cdfc2f24fe72a0b0751bb6
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
c970ec5  Deprecate sage.matrix.matrix

comment:13 Changed 5 years ago by
 Status changed from needs_review to positive_review
Since this was reviewed before, I'm setting this back to positive review.
comment:14 Changed 5 years ago by
I would have been happier with a patchbot check.
comment:15 Changed 5 years ago by
Patchbot check passed.
comment:16 Changed 4 years ago by
 Branch changed from u/jdemeyer/deprecate_sage_matrix_matrix to c970ec5871603a8ec8cdfc2f24fe72a0b0751bb6
 Resolution set to fixed
 Status changed from positive_review to closed
comment:17 Changed 4 years ago by
 Commit c970ec5871603a8ec8cdfc2f24fe72a0b0751bb6 deleted
This is not what I would call deprecation...
sage: from sage.matrix.matrix import Matrix /opt/sage/local/lib/python2.7/sitepackages/IPython/core/interactiveshell.py:2881: DeprecationWarning: the module sage.matrix.matrix is deprecated, import from sage.structure.element instead See http://trac.sagemath.org/24096 for details. exec(code_obj, self.user_global_ns, self.user_ns)  ImportError Traceback (most recent call last) <ipythoninput1cb253fa7b293> in <module>() > 1 from sage.matrix.matrix import Matrix ImportError: cannot import name Matrix
comment:18 Changed 9 months ago by
Removed in #32417
New commits:
Deprecate sage.matrix.matrix