Opened 5 years ago

Closed 5 years ago

#24095 closed enhancement (fixed)

Part 2, "Posets.*" to "posets.*"

Reported by: Jori Mäntysalo Owned by:
Priority: minor Milestone: sage-8.1
Component: documentation Keywords:
Cc: Travis Scrimshaw Merged in:
Authors: Jori Mäntysalo Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: b2a597b (Commits, GitHub, GitLab) Commit: b2a597bb0da0a292e78b47a0d2e9159b7cc28bd9
Dependencies: Stopgaps:

Status badges

Description

Followup to #24009.

Change History (7)

comment:1 Changed 5 years ago by Jori Mäntysalo

Branch: → u/jmantysalo/posets-Posets-part-2

comment:2 Changed 5 years ago by Jori Mäntysalo

Commit: → e559cbafb9201946a826ce3f15b854682a786188
Status: new → needs_review

What we should do to tests in books/* tests? We can't change text already printed.

New commits:

​e559cbaBikeshedding.

comment:3 Changed 5 years ago by Travis Scrimshaw

I would say leave them until we formally deprecate Posets.*

comment:4 Changed 5 years ago by git

Commit: e559cbafb9201946a826ce3f15b854682a786188 → b2a597bb0da0a292e78b47a0d2e9159b7cc28bd9

Branch pushed to git repo; I updated commit sha1. New commits:

​b2a597bManual revert.

comment:5 in reply to:  3 Changed 5 years ago by Jori Mäntysalo

Replying to tscrim:

I would say leave them until we formally deprecate Posets.*

OK.

(Maybe some day I learn to use git.)

comment:6 Changed 5 years ago by Travis Scrimshaw

Reviewers: → Travis Scrimshaw
Status: needs_review → positive_review
Type: PLEASE CHANGE → enhancement

Thanks. LGTM.

comment:7 Changed 5 years ago by Volker Braun

Branch: u/jmantysalo/posets-Posets-part-2 → b2a597bb0da0a292e78b47a0d2e9159b7cc28bd9
Resolution: → fixed
Status: positive_review → closed
Note: See TracTickets for help on using tickets.