Opened 4 years ago

Closed 4 years ago

#24092 closed defect (fixed)

Make brial depend on pip

Reported by: fbissey Owned by:
Priority: blocker Milestone: sage-8.1
Component: packages: standard Keywords:
Cc: jdemeyer, vbraun Merged in:
Authors: François Bissey Reviewers: Erik Bray
Report Upstream: N/A Work issues:
Branch: 6dd69fd (Commits, GitHub, GitLab) Commit: 6dd69fd79f45218a900bd4fb98a98d2ec0480138
Dependencies: Stopgaps:

Status badges

Description

In #21083, brial was updated and now pip is used to install the sage bindings. But the dependency on pip was forgotten.

Change History (4)

comment:1 Changed 4 years ago by fbissey

  • Authors set to François Bissey
  • Branch set to u/fbissey/brial_pip
  • Commit set to 6dd69fd79f45218a900bd4fb98a98d2ec0480138
  • Status changed from new to needs_review

Ready for review.


New commits:

6dd69fdAdd pip to brial's dependencies, replace the use of PIP_INSTALL as per #24014.

comment:2 Changed 4 years ago by tscrim

  • Cc jdemeyer vbraun added

comment:3 Changed 4 years ago by embray

  • Reviewers set to Erik Bray
  • Status changed from needs_review to positive_review

Makes sense.

comment:4 Changed 4 years ago by vbraun

  • Branch changed from u/fbissey/brial_pip to 6dd69fd79f45218a900bd4fb98a98d2ec0480138
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.