Opened 2 years ago

Closed 2 years ago

#24090 closed enhancement (fixed)

Clean up matrix hashing

Reported by: jdemeyer Owned by:
Priority: major Milestone: sage-8.1
Component: linear algebra Keywords:
Cc: Merged in:
Authors: Jeroen Demeyer Reviewers: Vincent Delecroix
Report Upstream: N/A Work issues:
Branch: 18fefb0 (Commits) Commit: 18fefb0820351865f62adc20742f7f6c7d3bd9dc
Dependencies: Stopgaps:

Description

Remove the superfluous __hash__ methods everywhere. Speed up the caching as cdef attribute.

Remove _set_pivots which is only used in one place.

Remove these comment blocks which are outdated and make it harder to grep for what you need:

    #################################################################
    # LEVEL 1 functionality
    # * __cinit__
    # * __init__
    # * __dealloc__
    # * set_unsafe(self, size_t i, size_t j, x)
    # * get_unsafe(self, size_t i, size_t j)
    ################################################################

Change History (5)

comment:1 Changed 2 years ago by jdemeyer

  • Branch set to u/jdemeyer/ticket/24090

comment:2 Changed 2 years ago by git

  • Commit set to 18fefb0820351865f62adc20742f7f6c7d3bd9dc

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

18fefb0Clean up matrix hashing

comment:3 Changed 2 years ago by jdemeyer

  • Status changed from new to needs_review

comment:4 Changed 2 years ago by vdelecroix

  • Reviewers set to Vincent Delecroix
  • Status changed from needs_review to positive_review

Good to go!

comment:5 Changed 2 years ago by vbraun

  • Branch changed from u/jdemeyer/ticket/24090 to 18fefb0820351865f62adc20742f7f6c7d3bd9dc
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.