Opened 5 years ago

Closed 4 years ago

#24083 closed enhancement (fixed)

Factory function for TorsionQuadraticForms

Reported by: sbrandhorst Owned by:
Priority: major Milestone: sage-8.1
Component: linear algebra Keywords:
Cc: Merged in:
Authors: Kenji Hashimoto Reviewers: Simon Brandhorst
Report Upstream: N/A Work issues:
Branch: 73bd99e (Commits, GitHub, GitLab) Commit: 73bd99e0941edc11b8e35a3165ed2ee900b6a55e
Dependencies: #23699 Stopgaps:

Status badges

Description

Create a non-degenerate TorsionQuadraticModule with value group QQ/ZZ or QQ/2ZZ from a rational matrix.

Change History (12)

comment:1 Changed 4 years ago by sbrandhorst

  • Branch set to u/sbrandhorst/factory_function_for_torsionquadraticforms

comment:2 Changed 4 years ago by khashimoto

  • Commit set to d320c40c5caec6dab6f4d2d9704e757dd5e48e28
  • Dependencies changed from #23699 to #23699,#23958

New commits:

daada4eMerge branch 't/23699/torsion_quadratic_module_symmetric' into t/24083/factory_function_for_torsionquadraticforms
a7c43f4 a first try
d320c40Merge branch 'develop' of git://trac.sagemath.org/sage into t/24083/factory_function_for_torsionquadraticforms

comment:3 Changed 4 years ago by khashimoto

  • Branch changed from u/sbrandhorst/factory_function_for_torsionquadraticforms to u/khashimoto/factory_function_for_torsionquadraticforms

comment:4 Changed 4 years ago by git

  • Commit changed from d320c40c5caec6dab6f4d2d9704e757dd5e48e28 to 328e5432d8525c280927a2e7d562fc835cd0d3fd

Branch pushed to git repo; I updated commit sha1. New commits:

aeb35faadded TorsionQuadraticForm for torsion quadratic forms
328e543Added TorsionQuadraticForm for torsion quadratic modules

comment:5 Changed 4 years ago by khashimoto

  • Authors set to Kenji Hashimoto
  • Status changed from new to needs_review

comment:6 Changed 4 years ago by git

  • Commit changed from 328e5432d8525c280927a2e7d562fc835cd0d3fd to c4bed4fb9993edb8ed90af2afbac200b8d16060f

Branch pushed to git repo; I updated commit sha1. New commits:

c4bed4fChanged only documentation and indentation

comment:7 Changed 4 years ago by git

  • Commit changed from c4bed4fb9993edb8ed90af2afbac200b8d16060f to 73bd99e0941edc11b8e35a3165ed2ee900b6a55e

Branch pushed to git repo; I updated commit sha1. New commits:

73bd99eAdded TorsionQuadraticForm to global name space

comment:8 Changed 4 years ago by sbrandhorst

  • Dependencies changed from #23699,#23958 to #23699

comment:9 Changed 4 years ago by sbrandhorst

  • Status changed from needs_review to positive_review

Looks good.

comment:10 Changed 4 years ago by vbraun

  • Status changed from positive_review to needs_work

Reviewer name is missing

comment:11 Changed 4 years ago by sbrandhorst

  • Reviewers set to Simon Brandhorst
  • Status changed from needs_work to positive_review

Arg, I tend to forget that. Sorry for the extra work. I'll promise to be more careful :-).

comment:12 Changed 4 years ago by vbraun

  • Branch changed from u/khashimoto/factory_function_for_torsionquadraticforms to 73bd99e0941edc11b8e35a3165ed2ee900b6a55e
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.