Opened 4 years ago

Closed 4 years ago

#24079 closed enhancement (fixed)

Simplify number field division

Reported by: jdemeyer Owned by:
Priority: major Milestone: sage-8.1
Component: number fields Keywords:
Cc: Merged in:
Authors: Jeroen Demeyer Reviewers: Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: 1d56994 (Commits, GitHub, GitLab) Commit: 1d56994a76ca55601c39c1945feade5e7cbada0c
Dependencies: Stopgaps:

Status badges

Description (last modified by jdemeyer)

Number field division is implemented in a convoluted way in every element class separately but there is no need for this. It suffices to define _div_ on the base class to implement a / b as a * ~b. We do need to be careful that the division of order elements becomes a number field element, see #4190.

Change History (5)

comment:1 Changed 4 years ago by jdemeyer

  • Branch set to u/jdemeyer/ticket/24079

comment:2 Changed 4 years ago by jdemeyer

  • Commit set to 1d56994a76ca55601c39c1945feade5e7cbada0c
  • Status changed from new to needs_review

New commits:

1d56994Simplify number field division

comment:3 Changed 4 years ago by jdemeyer

  • Description modified (diff)

comment:4 Changed 4 years ago by chapoton

  • Reviewers set to Frédéric Chapoton
  • Status changed from needs_review to positive_review


comment:5 Changed 4 years ago by vbraun

  • Branch changed from u/jdemeyer/ticket/24079 to 1d56994a76ca55601c39c1945feade5e7cbada0c
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.