Opened 4 years ago

Last modified 4 years ago

#24053 new defect

Insufficient testing coverage for asymptotics_multiple()

Reported by: jdemeyer Owned by:
Priority: major Milestone: sage-8.1
Component: asymptotic expansions Keywords:
Cc: dkrenn, araichev Merged in:
Authors: Reviewers:
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description (last modified by jdemeyer)

In the file src/sage/rings/asymptotic/asymptotics_multivariate_generating_functions.py, the function asymptotics_multiple() is insufficiently doctested. It seems that only the case "n == d" is tested. All tests in sage/rings/asymptotic still pass when applying

  • src/sage/rings/asymptotic/asymptotics_multivariate_generating_functions.py

    a b class FractionWithFactoredDenominator(RingElement): 
    22042204            return (exp_scale ** asy_var * subexp_part, exp_scale, subexp_part)
    22052205
    22062206        # Case n < d.
     2207        assert(False)
    22072208        # If P is a tuple of rationals, then compute with it directly.
    22082209        # Otherwise, compute symbolically and plug in P at the end.
    22092210        if vector(P.values()) not in QQ ** d:

I discovered this because the function binomial is imported from a deprecated module, but no deprecation warning triggers.

Possibly related: #19989

Change History (3)

comment:1 Changed 4 years ago by jdemeyer

  • Description modified (diff)

comment:2 Changed 4 years ago by jdemeyer

  • Description modified (diff)

comment:3 Changed 4 years ago by jdemeyer

  • Description modified (diff)
Note: See TracTickets for help on using tickets.