Opened 4 years ago
Closed 4 years ago
#24049 closed enhancement (fixed)
remove imports deprecated in 19879
Reported by:  chapoton  Owned by:  

Priority:  major  Milestone:  sage8.1 
Component:  python3  Keywords:  
Cc:  tscrim, jdemeyer, jhpalmieri, aapitzsch, fbissey  Merged in:  
Authors:  Frédéric Chapoton  Reviewers:  Jeroen Demeyer 
Report Upstream:  N/A  Work issues:  
Branch:  39ac047 (Commits, GitHub, GitLab)  Commit:  39ac0479b0305842fed91e9c9b0ed97ca99f9ecf 
Dependencies:  Stopgaps: 
Description
as this helps to enhance the restart under python3
Change History (13)
comment:1 Changed 4 years ago by
 Branch set to u/chapoton/24049
 Commit set to 016cd7a25c740b24f6b28515d2232fc6d2dfa7e4
 Status changed from new to needs_review
comment:2 Changed 4 years ago by
 Status changed from needs_review to needs_work
All the bots are breaking...
comment:3 Changed 4 years ago by
 Commit changed from 016cd7a25c740b24f6b28515d2232fc6d2dfa7e4 to a20b98b103303dfdebcc69c32c79e055d231b923
Branch pushed to git repo; I updated commit sha1. New commits:
a20b98b  fixing 2 imports

comment:4 Changed 4 years ago by
 Status changed from needs_work to needs_review
comment:5 Changed 4 years ago by
 Reviewers set to Jeroen Demeyer
 Status changed from needs_review to needs_work
Those two imports of binomial
are not actually used, so better just remove them. That is also the reason why the deprecation warning did not trigger: with deprecated lazy imports, the warning is only shown when using the functions.
comment:6 Changed 4 years ago by
 Commit changed from a20b98b103303dfdebcc69c32c79e055d231b923 to 90ef1deb1c77b4f4de1d28087a221069797877ad
Branch pushed to git repo; I updated commit sha1. New commits:
90ef1de  remove one import

comment:7 Changed 4 years ago by
 Status changed from needs_work to needs_review
one of them is used, I think. I removed the other one
comment:8 Changed 4 years ago by
 Commit changed from 90ef1deb1c77b4f4de1d28087a221069797877ad to 63dc58556a0310b3de2b99b16460165ca78975f5
Branch pushed to git repo; I updated commit sha1. New commits:
63dc585  fixing one import

comment:9 Changed 4 years ago by
 Commit changed from 63dc58556a0310b3de2b99b16460165ca78975f5 to 39ac0479b0305842fed91e9c9b0ed97ca99f9ecf
Branch pushed to git repo; I updated commit sha1. New commits:
39ac047  remove import

comment:10 Changed 4 years ago by
green bot, please review
comment:11 Changed 4 years ago by
Interestingly, the binomial
in src/sage/rings/asymptotic/asymptotics_multivariate_generating_functions.py
is "used" in the code but no doctest tests it (otherwise we would see the deprecation warning). I created #24053 for that.
comment:12 Changed 4 years ago by
 Status changed from needs_review to positive_review
comment:13 Changed 4 years ago by
 Branch changed from u/chapoton/24049 to 39ac0479b0305842fed91e9c9b0ed97ca99f9ecf
 Resolution set to fixed
 Status changed from positive_review to closed
New commits:
remove import deprecated in 19879