Opened 4 years ago

Closed 4 years ago

#24041 closed enhancement (fixed)

Remove deprecation warnings introduced in 19550 and 21111

Reported by: dcoudert Owned by:
Priority: major Milestone: sage-8.1
Component: graph theory Keywords:
Cc: jmantysalo Merged in:
Authors: David Coudert Reviewers: Jori Mäntysalo
Report Upstream: N/A Work issues:
Branch: 6713f87 (Commits, GitHub, GitLab) Commit: 6713f87f37d83a1fe89639f4b8f9206674b1621b
Dependencies: Stopgaps:

Status badges

Description (last modified by dcoudert)

The deprecation warning introduced in #19550 about changing parameter name from method to algorithm in some graphs methods is 2 years old. So it's time to remove it.

Similarly, the warning introduced in #21111 about renaming parameter certifyto certificate is 14 months old. Time to remove it.

Change History (6)

comment:1 Changed 4 years ago by dcoudert

  • Branch set to u/dcoudert/24041
  • Commit set to 5fb046bb69f6036759291a6a8371aeb55f2f6859
  • Description modified (diff)
  • Status changed from new to needs_review
  • Summary changed from Remove deprecation warning introduced in 19550 to Remove deprecation warnings introduced in 19550 and 21111

New commits:

885b6bftrac #24041: remove deprecation warning 19550
fea188etrac #24041: remove deprecation warning 21111
5fb046btrac #24041: correct doctests

comment:2 Changed 4 years ago by git

  • Commit changed from 5fb046bb69f6036759291a6a8371aeb55f2f6859 to 6713f87f37d83a1fe89639f4b8f9206674b1621b

Branch pushed to git repo; I updated commit sha1. New commits:

6713f87trac #24041: remove useless import in bliss

comment:3 Changed 4 years ago by dcoudert

  • Cc jmantysalo added

comment:4 Changed 4 years ago by jmantysalo

  • Reviewers set to Jori Mäntysalo

I'll take a look.

comment:5 Changed 4 years ago by jmantysalo

  • Status changed from needs_review to positive_review

This is OK.

comment:6 Changed 4 years ago by vbraun

  • Branch changed from u/dcoudert/24041 to 6713f87f37d83a1fe89639f4b8f9206674b1621b
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.