Opened 2 years ago

Closed 2 years ago

#24032 closed enhancement (fixed)

add noncrossing partition lattices to poset catalog

Reported by: chapoton Owned by:
Priority: major Milestone: sage-8.1
Component: combinatorics Keywords:
Cc: tscrim, stumpc5, nthiery, jmantysalo Merged in:
Authors: Frédéric Chapoton Reviewers: Christian Stump
Report Upstream: N/A Work issues:
Branch: 6f990dc (Commits) Commit: 6f990dccb84cffe5df8fc497a3c1e7ad4db8796e
Dependencies: Stopgaps:


and make them work for Coxeter groups

Change History (5)

comment:1 Changed 2 years ago by chapoton

  • Branch set to u/chapoton/24032
  • Cc tscrim stumpc5 nthiery jmantysalo added
  • Commit set to c9e59789980d8b1e171966c5f8d4b17ad8eec4e6
  • Status changed from new to needs_review

New commits:

c9e5978add noncrossing partitions lattices to poset catalog

comment:2 Changed 2 years ago by stumpc5

Looks good to me at first glance, though the "add noncrossing partition lattices to poset catalog" and the "make them work for Coxeter groups" seem to be totally unrelated. I give it a positive if there is a patchbot which is happy with the doctests...

comment:3 Changed 2 years ago by git

  • Commit changed from c9e59789980d8b1e171966c5f8d4b17ad8eec4e6 to 6f990dccb84cffe5df8fc497a3c1e7ad4db8796e

Branch pushed to git repo; I updated commit sha1. New commits:

6f990dctrac 24032 typo

comment:4 Changed 2 years ago by chapoton

  • Reviewers set to Christian Stump
  • Status changed from needs_review to positive_review

green bot, setting to positive. Thanks for the review, Christian.

comment:5 Changed 2 years ago by vbraun

  • Branch changed from u/chapoton/24032 to 6f990dccb84cffe5df8fc497a3c1e7ad4db8796e
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.