Opened 2 years ago

Last modified 2 years ago

#24027 new enhancement

Make FGP_Modules great again (work over PIDs different from ZZ)

Reported by: sbrandhorst Owned by:
Priority: major Milestone: sage-8.2
Component: linear algebra Keywords:
Cc: Merged in:
Authors: Reviewers:
Report Upstream: N/A Work issues:
Branch: u/sbrandhorst/make_fgp_module_work_over_pids_different_from_zz_ (Commits) Commit: b21796b318059e09a7ec9017b68e22dd5f4d4711
Dependencies: #24031 Stopgaps:

Description

FGP_Module was written to model finitely generated modules over a principal ideal domain. Currently, only ZZ is tested and works. This ticket is to make it work for all PIDs

Issues:

  • .denominator() over number fields behaves differently from over ZZ.

Change History (4)

comment:1 Changed 2 years ago by sbrandhorst

  • Milestone changed from sage-feature to sage-8.2

comment:2 Changed 2 years ago by sbrandhorst

sage: from sage.modules.fg_pid.fgp_module import *
sage: L.<w> = NumberField(x^2 - x + 2)
sage:  OL = L.ring_of_integers()
sage: V = OL**3; W = V.span([[0,w,0], [1,0,1-w]], OL)
sage: Q = FGP_Module(V,W)
sage: TestSuite(Q).run()
sage: 

Runs now.

comment:3 Changed 2 years ago by sbrandhorst

  • Branch set to u/sbrandhorst/make_fgp_module_work_over_pids_different_from_zz_

comment:4 Changed 2 years ago by sbrandhorst

  • Commit set to b21796b318059e09a7ec9017b68e22dd5f4d4711
  • Dependencies set to #24031
  • Summary changed from Make FGP_Module work over PIDs different from ZZ. to Make FGP_Modules great again (work over PIDs different from ZZ)

New commits:

b21796bAlternative for ._clear_denom() where it is not defined.
Note: See TracTickets for help on using tickets.