#24018 closed task (fixed)
Remove PIP_INSTALL from sageenv
Reported by:  embray  Owned by:  embray 

Priority:  minor  Milestone:  sage8.6 
Component:  build  Keywords:  pip 
Cc:  slelievre, tscrim, embray, jdemeyer  Merged in:  
Authors:  Frédéric Chapoton  Reviewers:  Erik Bray 
Report Upstream:  N/A  Work issues:  
Branch:  ef11f05 (Commits, GitHub, GitLab)  Commit:  ef11f05ee99b6c751a3188c9d29ee37da0e111fa 
Dependencies:  Stopgaps: 
Description
#24014 deprecated the PIP_INSTALL
environment variable in favor of the sdh_pip_install
helper function. This ticket is to remove PIP_INSTALL
entirely.
Change History (12)
comment:1 Changed 5 years ago by
 Owner changed from (none) to embray
comment:2 Changed 5 years ago by
comment:3 Changed 5 years ago by
 Cc slelievre added
 Dependencies changed from #24014 to #23983, #24014, #24092
 Keywords pip added
In #24014, getting rid of the PIP_INSTALL
environment variable was postponed for the sake of work in progress on brial
and dot2tex
.
Since #24092, brial
no longer uses PIP_INSTALL
.
Now that #23983 is closed, all that remains to do is to stop using PIP_INSTALL
for dot2tex
, allowing to remove PIP_INSTALL
entirely.
comment:5 Changed 4 years ago by
 Milestone changed from sage8.2 to sage8.3
comment:6 Changed 4 years ago by
 Milestone changed from sage8.3 to sage8.4
comment:7 Changed 4 years ago by
 Milestone changed from sage8.4 to sage8.5
comment:8 Changed 4 years ago by
 Branch set to u/chapoton/24018
 Cc embray added
 Commit set to ef11f05ee99b6c751a3188c9d29ee37da0e111fa
 Dependencies #23983, #24014, #24092 deleted
 Status changed from new to needs_review
New commits:
ef11f05  work on dot2tex spkg

comment:9 Changed 4 years ago by
 Cc jdemeyer added
Jeroen, would you have some time to look at this one ? This should be pretty clear, removal of the last instance of this variable. I have tested the package installation and it worked.
comment:10 Changed 4 years ago by
 Reviewers set to Erik Bray
 Status changed from needs_review to positive_review
In retrospect there is one small possible use for a variable like this, in case users for some particular reason needed to override and/or extend the default flags passed to pip. I could sort of envision a reason for that in theory, though I don't know one explicitly.
In any case, the current implementation wouldn't work that way anyways, and something more like PIP_INSTALL_FLAGS
would be better for that use case.
comment:11 Changed 4 years ago by
 Branch changed from u/chapoton/24018 to ef11f05ee99b6c751a3188c9d29ee37da0e111fa
 Resolution set to fixed
 Status changed from positive_review to closed
comment:12 Changed 4 years ago by
 Milestone changed from sage8.5 to sage8.6
This tickets were closed as fixed after the Sage 8.5 release.
Related: some Python packages don't use
pip
at all:For
setuptools
, this is obvious because it's a dependency ofpip
.