Opened 2 years ago

Closed 2 years ago

#24005 closed enhancement (fixed)

Remove "bzip2" from base packages

Reported by: jdemeyer Owned by:
Priority: minor Milestone: sage-8.2
Component: build Keywords:
Cc: jhpalmieri Merged in:
Authors: Jeroen Demeyer Reviewers: John Palmieri
Report Upstream: N/A Work issues:
Branch: 268a33e (Commits) Commit: 268a33ef9b7d793ab4575ff8914e4df040767799
Dependencies: Stopgaps:

Description

We no longer use bzip2 in the build system; we use a system Python to uncompress tarballs.

Change History (8)

comment:1 Changed 2 years ago by jdemeyer

  • Branch set to u/jdemeyer/remove__bzip2__from_base_packages

comment:2 Changed 2 years ago by jdemeyer

  • Commit set to 268a33ef9b7d793ab4575ff8914e4df040767799
  • Status changed from new to needs_review

New commits:

268a33eRemove bzip2 from base packages

comment:3 follow-up: Changed 2 years ago by jhpalmieri

When pcre builds, although I see

checking bzlib.h usability... yes
checking bzlib.h presence... yes
checking for bzlib.h... yes

I later see

    Link pcregrep with libbz2 ....... : no

Maybe we need to use the --enable-pcregrep-libbz2 flag when configuring. To do on a later ticket, if there is a need.

comment:4 Changed 2 years ago by jhpalmieri

  • Milestone changed from sage-8.1 to sage-8.2
  • Reviewers set to John Palmieri
  • Status changed from needs_review to positive_review

Looks good to me. Let's get it merged early in the 8.2 release cycle so it can get widely tested.

comment:5 Changed 2 years ago by jhpalmieri

I should also say that I didn't test this as carefully as maybe I should have. There is a copy of libbz2 in /usr/lib, and it might have been better to test without that. If I can figure out how to do that, maybe I will try. (Right now, though, sudo mv libbz2.1.0.dylib libbz2.1.0.dylib.TEMP results in Operation not permitted. OS X really doesn't want me to move that file.)

comment:6 Changed 2 years ago by jdemeyer

I simply grepped the log files of all packages for bz2, bzip2 and bunzip2 and added bzip2 as dependency where needed.

comment:7 in reply to: ↑ 3 Changed 2 years ago by jdemeyer

Replying to jhpalmieri:

When pcre builds, although I see

checking bzlib.h usability... yes
checking bzlib.h presence... yes
checking for bzlib.h... yes

I later see

    Link pcregrep with libbz2 ....... : no

Yes, I saw that. So maybe it doesn't actually depend on bzip2. Still, it doesn't hurt much to add this dependency even if it is not strictly needed.

comment:8 Changed 2 years ago by vbraun

  • Branch changed from u/jdemeyer/remove__bzip2__from_base_packages to 268a33ef9b7d793ab4575ff8914e4df040767799
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.