Opened 3 years ago

Closed 3 years ago

#23991 closed defect (fixed)

Update curl to 7.56.1

Reported by: jhpalmieri Owned by:
Priority: major Milestone: sage-8.1
Component: packages: standard Keywords:
Cc: Merged in:
Authors: John Palmieri Reviewers: Jeroen Demeyer
Report Upstream: N/A Work issues:
Branch: 2f1c87b (Commits) Commit: 2f1c87b1be6f94ccd5de1273ad89680464c26c47
Dependencies: Stopgaps:

Change History (20)

comment:1 Changed 3 years ago by jhpalmieri

  • Branch set to u/jhpalmieri/curl7.56

comment:2 Changed 3 years ago by jhpalmieri

  • Commit set to 4f92e31786e5408603ce01712dce700465894c6b
  • Status changed from new to needs_review

New commits:

4f92e31trac 23991: update curl to 7.56.0

comment:3 Changed 3 years ago by jhpalmieri

One test in the testsuite fails for me:

[curl-7.56.0] test 1014...Mismatch in features lists:
[curl-7.56.0] curl:        asynchdns ipv6 libz multissl ntlm ntlm_wb ssl tls-srp unixsockets
[curl-7.56.0] curl-config: asynchdns https-proxy ipv6 libz multissl ntlm ntlm_wb ssl tls-srp unixsockets
[curl-7.56.0]  postcheck FAILED

But the testsuite has failed in the past for OS X: see #22686. So I don't think this should be an obstacle.

Last edited 3 years ago by jhpalmieri (previous) (diff)

comment:4 Changed 3 years ago by jhpalmieri

On another machine the test suite passes, so maybe it's because I installed the Sage openssl package that is causing the failure.

Last edited 3 years ago by jhpalmieri (previous) (diff)

comment:5 follow-up: Changed 3 years ago by ayyer

Sorry if this is a newbie question. I'm trying to install patch #23898 on OSX High Sierra. Curl-7.53.1 fails for me too. I deleted the old version and downloaded curl-7.56.0 in the upstream folder and reran

SAGE_INSTALL_GCC=yes make ptestlong

but it again downloaded curl-7.53.1 and gave the same error. What should I do to avoid this? Thanks.

comment:6 in reply to: ↑ 5 Changed 3 years ago by ayyer

but it again downloaded curl-7.53.1 and gave the same error. What should I do to avoid this?

I got this working by manually changing the two files as described in the ticket. Sorry for polluting the discussion.

comment:7 follow-up: Changed 3 years ago by dimpase

Why do we need to build curl on OSX, is there a reason?

Isn't curl is in the set of command-line tools which are shipped by default, even without Xcode installed?

comment:8 in reply to: ↑ 7 Changed 3 years ago by jdemeyer

Replying to dimpase:

Why do we need to build curl on OSX, is there a reason?

Isn't curl is in the set of command-line tools which are shipped by default, even without Xcode installed?

curl isn't just a command-line program. Probably the other curl stuff (in particular the header files) isn't installed by default.

comment:9 Changed 3 years ago by dimpase

Oh, you are right. Sorry for noise.

comment:10 follow-up: Changed 3 years ago by jhpalmieri

/usr/include is not present without Xcode and/or the command line tools. On a machine on which I've installed Xcode and the command line tools, I have /usr/lib/libcurl.4.dylib and a directory /usr/include/curl with various header files, so this might be good enough for what Sage needs. But we can think about that on another ticket.

comment:11 in reply to: ↑ 10 Changed 3 years ago by jdemeyer

Replying to jhpalmieri:

On a machine on which I've installed Xcode and the command line tools

...which you need anyway if you build Sage from source. That's good to know because it means that we can assume that those headers exist on OS X.

comment:12 Changed 3 years ago by jhpalmieri

Oh, it is also curl version 7.54.0, which is not that old.

comment:13 Changed 3 years ago by jhpalmieri

See #24081.

comment:14 Changed 3 years ago by jhpalmieri

(Let's keep this open because it might be worth upgrading curl anyway.)

comment:15 Changed 3 years ago by jdemeyer

  • Description modified (diff)
  • Priority changed from critical to major
  • Status changed from needs_review to needs_work
  • Summary changed from Update curl to 7.56.0 to Update curl to 7.56.1

comment:16 Changed 3 years ago by jdemeyer

  • Branch changed from u/jhpalmieri/curl7.56 to u/jdemeyer/curl7.56

comment:17 Changed 3 years ago by jdemeyer

  • Commit changed from 4f92e31786e5408603ce01712dce700465894c6b to 2f1c87b1be6f94ccd5de1273ad89680464c26c47
  • Reviewers set to Jeroen Demeyer
  • Status changed from needs_work to needs_review

7.56.0 -> 7.56.1


New commits:

2f1c87bTrac #23991: update curl to 7.56.1

comment:18 Changed 3 years ago by jdemeyer

Seems to work. John, I'll let you set positive_review if you agree.

comment:19 Changed 3 years ago by jhpalmieri

  • Status changed from needs_review to positive_review

Builds and passes its test-suite.

comment:20 Changed 3 years ago by vbraun

  • Branch changed from u/jdemeyer/curl7.56 to 2f1c87b1be6f94ccd5de1273ad89680464c26c47
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.