Opened 5 years ago

Closed 3 years ago

#23981 closed enhancement (invalid)

use _mul_ for the inner_product in FreeQuadraticModules

Reported by: Simon Brandhorst Owned by:
Priority: major Milestone: sage-duplicate/invalid/wontfix
Component: linear algebra Keywords:
Cc: David Roe Merged in:
Authors: Reviewers:
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

Overwrite _mul_ in sage.modules.free_quadratic_modules

x*y

Instead of

x.inner_product(y)

Is just so much nicer to read.

And if one is in a FreeQuadraticModule, then one is not interested in the doc product anyways but rather in the defined inner product. If one really needs to, one can still use x.dot_product()

Change History (5)

comment:1 Changed 5 years ago by Simon Brandhorst

Cc: David Roe added
Component: PLEASE CHANGElinear algebra
Type: PLEASE CHANGEenhancement

comment:2 Changed 5 years ago by Simon Brandhorst

Be aware of #23958

comment:3 Changed 4 years ago by Simon Brandhorst

Milestone: sage-8.1sage-duplicate/invalid/wontfix
Status: newneeds_review

In retrospect this is a bad idea. Consider for example a square matrix B and x in our free quadratic module It is clear what x*B*x should be. But if * is also the inner product, then x*(B*x) and (x*B)*x use the different inner product. This will cause a lot of trouble.

comment:4 Changed 3 years ago by Frédéric Chapoton

Status: needs_reviewpositive_review

can we close this ticket now ?

comment:5 Changed 3 years ago by Frédéric Chapoton

Resolution: invalid
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.