Opened 5 years ago

Last modified 5 years ago

#23974 needs_work enhancement

Improve docs of rank() in ell_rational_field

Reported by: jdemeyer Owned by:
Priority: major Milestone: sage-8.1
Component: elliptic curves Keywords:
Cc: mderickx Merged in:
Authors: Jeroen Demeyer, Maarten Derickx Reviewers:
Report Upstream: N/A Work issues:
Branch: public/23974 (Commits, GitHub, GitLab) Commit: 608f2314decb55e2bb981237362973536daea25f
Dependencies: #23962 Stopgaps:

Status badges

Description


Change History (3)

comment:1 Changed 5 years ago by jdemeyer

  • Dependencies set to #23962

comment:2 Changed 5 years ago by mderickx

  • Branch changed from public/23962 to public/23974
  • Commit changed from 48eaa0aa8c3573e266d6264e04b0cf9eeda873cb to 608f2314decb55e2bb981237362973536daea25f
  • Status changed from new to needs_review

Ok I fixed the issues you raised at #23962, except that I used 79 as a cutoff. Is there a reason why you said 72 characters instead of the 79 in pep8?

New commits:

​608f231Trac #23974: explain why we use database by default

comment:3 Changed 5 years ago by jdemeyer

  • Status changed from needs_review to needs_work

If you really want to test #23962, you should use E2 here: 

            sage: E1.rank(use_database=False)
            Traceback (most recent call last):
            ...
            RuntimeError: rank not provably correct (lower bound: 0)
            sage: E1._EllipticCurve_rational_field__rank
            (0, False)
            sage: E1.rank()
            0
            sage: E1._EllipticCurve_rational_field__rank
            (0, True)
Note: See TracTickets for help on using tickets.