Opened 3 years ago

Closed 3 years ago

#23970 closed enhancement (fixed)

Simpler caching in ell_rational_field

Reported by: jdemeyer Owned by:
Priority: major Milestone: sage-8.1
Component: elliptic curves Keywords:
Cc: mderickx Merged in:
Authors: Jeroen Demeyer Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 8bce6ff (Commits) Commit: 8bce6fff2c8425978a458b282256b4767651bbe3
Dependencies: #23962 Stopgaps:

Description

Instead of using a dict to cache results depending on proof, use a tuple (answer, proven). This is easier to understand and results in simpler code. This was already done for __rank in #23962.

Change History (7)

comment:1 Changed 3 years ago by jdemeyer

  • Dependencies set to #23962

comment:2 Changed 3 years ago by jdemeyer

  • Dependencies #23962 deleted

comment:3 Changed 3 years ago by jdemeyer

  • Branch set to u/jdemeyer/simpler_caching_in_ell_rational_field

comment:4 Changed 3 years ago by jdemeyer

  • Commit set to 8bce6fff2c8425978a458b282256b4767651bbe3
  • Status changed from new to needs_review

New commits:

3cff14crank() of elliptic curves should always consult Cremona database
8bce6ffSimpler caching in ell_rational_field

comment:5 Changed 3 years ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

LGTM.

comment:6 Changed 3 years ago by jdemeyer

  • Dependencies set to #23962

comment:7 Changed 3 years ago by vbraun

  • Branch changed from u/jdemeyer/simpler_caching_in_ell_rational_field to 8bce6fff2c8425978a458b282256b4767651bbe3
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.