Opened 4 years ago

Closed 4 years ago

#23966 closed defect (fixed)

Conversion from ZpFM to its fraction field incorrect

Reported by: saraedum Owned by:
Priority: major Milestone: sage-8.1
Component: padics Keywords:
Cc: roed Merged in:
Authors: David Roe Reviewers: Julian Rüth
Report Upstream: N/A Work issues:
Branch: b8de189 (Commits, GitHub, GitLab) Commit: b8de18928c9d5ec2e4aade83ab910e97673191d4
Dependencies: #23510 Stopgaps:

Status badges

Description 

sage: R = ZqFM(2)
sage: K = R.fraction_field()
sage: K(R.zero())
<blankline>

Change History (8)

comment:1 Changed 4 years ago by saraedum

  • Branch set to u/saraedum/conversion_from_zpfm_to_its_fraction_field_incorrect

comment:2 Changed 4 years ago by saraedum

  • Authors set to Julian Rüth
  • Branch u/saraedum/conversion_from_zpfm_to_its_fraction_field_incorrect deleted
  • Cc roed added
  • Status changed from new to needs_review

David, you know this code much better than I do. I have no idea if this is the best fix for this.

comment:3 Changed 4 years ago by roed

  • Branch set to u/saraedum/conversion_from_zpfm_to_its_fraction_field_incorrect
  • Commit set to 87c900cc682f0d52c7bc6e3ef23f466eba373939

Setting branch back....

New commits:

​87c900cnormalize() FP elements

comment:4 Changed 4 years ago by roed

  • Branch changed from u/saraedum/conversion_from_zpfm_to_its_fraction_field_incorrect to u/roed/conversion_from_zpfm_to_its_fraction_field_incorrect

comment:5 Changed 4 years ago by roed

  • Authors changed from Julian Rüth to David Roe
  • Commit changed from 87c900cc682f0d52c7bc6e3ef23f466eba373939 to b8de18928c9d5ec2e4aade83ab910e97673191d4
  • Reviewers set to Julian Rüth

Alright, I've taken a different approach, and added in a test.

Last 10 new commits:

​cb882fdUpdate add_bigoh to account for fixed-mod having a fraction field
​a826978Fix _tester_add_bigoh
​883e6b5Fix doctest in local_generic_element.pyx
​52cbd2aMerge branch 'u/roed/fixed_mod_frac_field' of git://trac.sagemath.org/sage into t/23510/fixed_mod_frac_field
​bc59ffaMerge branch 't/14825/polynomial_representation_of_a_padic_number' into t/23510/fixed_mod_frac_field
​3292259Merge branch 'u/saraedum/fixed_mod_frac_field' of git://trac.sagemath.org/sage into t/23510/fixed_mod_frac_field
​dad02c7Merge branch 'u/saraedum/fixed_mod_frac_field' of git://trac.sagemath.org/sage into t/23510/fixed_mod_frac_field
​189ac2bAdd _test_fraction_field to the coercion tutorial
​98d8256Merge branch 'u/roed/fixed_mod_frac_field' of git://trac.sagemath.org/sage into develop
​b8de189Different fix for 23966, add doctest

comment:6 Changed 4 years ago by roed

  • Dependencies set to #23510

Most of the changes visible are from #23510. This ticket is basically the changes to FP_template.pxi.

comment:7 Changed 4 years ago by saraedum

  • Status changed from needs_review to positive_review

there is one failing doctest from the patchbot which should be unrelated.

comment:8 Changed 4 years ago by vbraun

  • Branch changed from u/roed/conversion_from_zpfm_to_its_fraction_field_incorrect to b8de18928c9d5ec2e4aade83ab910e97673191d4
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.