Opened 5 years ago

Closed 5 years ago

#23965 closed defect (fixed)

Coercion to fraction field is injective

Reported by: Julian Rüth Owned by:
Priority: major Milestone: sage-8.1
Component: padics Keywords:
Cc: Merged in:
Authors: Julian Rüth Reviewers: David Roe
Report Upstream: N/A Work issues:
Branch: a4d9ad6 (Commits, GitHub, GitLab) Commit: a4d9ad6429371fc8cca4b60353642bb36cf1402a
Dependencies: #23510 Stopgaps:

Status badges

Description (last modified by Julian Rüth)

Currently this coercion is not detected as being injective:

sage: R=ZpFM(3)
sage: K=R.fraction_field()
sage: K.coerce_map_from(R).is_injective()
NotImplementedError

Change History (10)

comment:1 Changed 5 years ago by Julian Rüth

Branch: u/saraedum/coercion_to_fraction_field_is_injective

comment:2 Changed 5 years ago by Julian Rüth

Commit: 55b33e4ecbe79e0731d6f14a2f39afeb5f668689
Description: modified (diff)

New commits:

55b33e4Coercions to the fraction field are injective

comment:3 Changed 5 years ago by Julian Rüth

Authors: Julian Rüth

comment:4 Changed 5 years ago by Julian Rüth

Status: newneeds_review

comment:5 Changed 5 years ago by Julian Rüth

Dependencies: #23510

comment:6 Changed 5 years ago by David Roe

Branch: u/saraedum/coercion_to_fraction_field_is_injectiveu/roed/coercion_to_fraction_field_is_injective

comment:7 Changed 5 years ago by David Roe

Commit: 55b33e4ecbe79e0731d6f14a2f39afeb5f668689a4d9ad6429371fc8cca4b60353642bb36cf1402a

I merged in #23510 and added a try/except block around the call to fraction_field(), since this can raise a TypeError. If you're happy with this change, positive review once tests pass.


Last 10 new commits:

cb882fdUpdate add_bigoh to account for fixed-mod having a fraction field
a826978Fix _tester_add_bigoh
883e6b5Fix doctest in local_generic_element.pyx
52cbd2aMerge branch 'u/roed/fixed_mod_frac_field' of git://trac.sagemath.org/sage into t/23510/fixed_mod_frac_field
bc59ffaMerge branch 't/14825/polynomial_representation_of_a_padic_number' into t/23510/fixed_mod_frac_field
3292259Merge branch 'u/saraedum/fixed_mod_frac_field' of git://trac.sagemath.org/sage into t/23510/fixed_mod_frac_field
dad02c7Merge branch 'u/saraedum/fixed_mod_frac_field' of git://trac.sagemath.org/sage into t/23510/fixed_mod_frac_field
189ac2bAdd _test_fraction_field to the coercion tutorial
df62c48Merge branch 'u/roed/fixed_mod_frac_field' of git://trac.sagemath.org/sage into t/23965/fracfield_coercion_injective
a4d9ad6Catch exceptions raised by attempting to find fraction field

comment:8 Changed 5 years ago by Julian Rüth

Reviewers: David Roe
Work issues: doctests pass ⇒ positive review

comment:9 Changed 5 years ago by David Roe

Status: needs_reviewpositive_review
Work issues: doctests pass ⇒ positive review

Tests pass.

comment:10 Changed 5 years ago by Volker Braun

Branch: u/roed/coercion_to_fraction_field_is_injectivea4d9ad6429371fc8cca4b60353642bb36cf1402a
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.