Opened 3 years ago
Closed 3 years ago
#23965 closed defect (fixed)
Coercion to fraction field is injective
Reported by: | saraedum | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-8.1 |
Component: | padics | Keywords: | |
Cc: | Merged in: | ||
Authors: | Julian Rüth | Reviewers: | David Roe |
Report Upstream: | N/A | Work issues: | |
Branch: | a4d9ad6 (Commits) | Commit: | a4d9ad6429371fc8cca4b60353642bb36cf1402a |
Dependencies: | #23510 | Stopgaps: |
Description (last modified by )
Currently this coercion is not detected as being injective:
sage: R=ZpFM(3) sage: K=R.fraction_field() sage: K.coerce_map_from(R).is_injective() NotImplementedError
Change History (10)
comment:1 Changed 3 years ago by
- Branch set to u/saraedum/coercion_to_fraction_field_is_injective
comment:2 Changed 3 years ago by
- Commit set to 55b33e4ecbe79e0731d6f14a2f39afeb5f668689
- Description modified (diff)
comment:3 Changed 3 years ago by
comment:4 Changed 3 years ago by
- Status changed from new to needs_review
comment:5 Changed 3 years ago by
- Dependencies set to #23510
comment:6 Changed 3 years ago by
- Branch changed from u/saraedum/coercion_to_fraction_field_is_injective to u/roed/coercion_to_fraction_field_is_injective
comment:7 Changed 3 years ago by
- Commit changed from 55b33e4ecbe79e0731d6f14a2f39afeb5f668689 to a4d9ad6429371fc8cca4b60353642bb36cf1402a
I merged in #23510 and added a try/except block around the call to fraction_field()
, since this can raise a TypeError
. If you're happy with this change, positive review once tests pass.
Last 10 new commits:
cb882fd | Update add_bigoh to account for fixed-mod having a fraction field
|
a826978 | Fix _tester_add_bigoh
|
883e6b5 | Fix doctest in local_generic_element.pyx
|
52cbd2a | Merge branch 'u/roed/fixed_mod_frac_field' of git://trac.sagemath.org/sage into t/23510/fixed_mod_frac_field
|
bc59ffa | Merge branch 't/14825/polynomial_representation_of_a_padic_number' into t/23510/fixed_mod_frac_field
|
3292259 | Merge branch 'u/saraedum/fixed_mod_frac_field' of git://trac.sagemath.org/sage into t/23510/fixed_mod_frac_field
|
dad02c7 | Merge branch 'u/saraedum/fixed_mod_frac_field' of git://trac.sagemath.org/sage into t/23510/fixed_mod_frac_field
|
189ac2b | Add _test_fraction_field to the coercion tutorial
|
df62c48 | Merge branch 'u/roed/fixed_mod_frac_field' of git://trac.sagemath.org/sage into t/23965/fracfield_coercion_injective
|
a4d9ad6 | Catch exceptions raised by attempting to find fraction field
|
comment:8 Changed 3 years ago by
- Reviewers set to David Roe
- Work issues set to doctests pass ⇒ positive review
comment:9 Changed 3 years ago by
- Status changed from needs_review to positive_review
- Work issues doctests pass ⇒ positive review deleted
Tests pass.
comment:10 Changed 3 years ago by
- Branch changed from u/roed/coercion_to_fraction_field_is_injective to a4d9ad6429371fc8cca4b60353642bb36cf1402a
- Resolution set to fixed
- Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
New commits:
Coercions to the fraction field are injective