Opened 5 years ago

Closed 5 years ago

#23953 closed enhancement (fixed)

Iterator for hypergeometric motives

Reported by: Kiran Kedlaya Owned by:
Priority: minor Milestone: sage-8.1
Component: modular forms Keywords: sd91
Cc: Merged in:
Authors: Kiran Kedlaya Reviewers: David Roe
Report Upstream: N/A Work issues:
Branch: 949a775 (Commits, GitHub, GitLab) Commit: 949a775d11166c985cb56d03c826c6674cb7d611
Dependencies: #23671 Stopgaps:

Status badges

Description

Ticket #23671 provides the function possible_hypergeometric_data which returns a list of all hypergeometric data with prescribed degree (and optionally weight). It would be better to also provide an iterator, so that one can do a list comprehension to further filter the results without instantiating the entire list.

Change History (9)

comment:1 Changed 5 years ago by Kiran Kedlaya

Branch: → u/kedlaya/iterator_for_hypergeometric_motives

comment:2 Changed 5 years ago by Kiran Kedlaya

Commit: → a9d41136328daf5be6706d45a9e2cd96a0e22ec6
Dependencies: → #23671
Status: new → needs_review

Last 10 new commits:

​656112fCorrect description of sign
​4179f4bMore minor edits
​cc53131Typo fix
​3cdb07ctrac 23671 fix wrong syntax for raise
​cd7c290Merge branch 'u/chapoton/23671' in 8.1.b6
​1d1039ftrac 23671 moving refs to the huge list of refs
​12aa8f2trac 23671 better ref to slides
​de3f9cbReviewer changes to 23671
​0c54a65Add cached_method to hypergeometric motives
​a9d4113Implemented iterator for hypergeometric motives

comment:3 Changed 5 years ago by git

Commit: a9d41136328daf5be6706d45a9e2cd96a0e22ec6 → d60b78eac5a11109214be9be320c282001a0ced3

Branch pushed to git repo; I updated commit sha1. New commits:

​d60b78eAdd import of itertools.combinations

comment:4 Changed 5 years ago by David Roe

Authors: → Kiran Kedlaya
Reviewers: → David Roe

Positive review once tests pass.

comment:5 Changed 5 years ago by David Roe

Branch: u/kedlaya/iterator_for_hypergeometric_motives → u/roed/iterator_for_hypergeometric_motives

comment:6 Changed 5 years ago by David Roe

Commit: d60b78eac5a11109214be9be320c282001a0ced3 → 316ab9b04b7d917d5b64fdd1e6d6fe0c5ac2f0b6
Status: needs_review → positive_review

Merged in the changes the remove the tab. The other tests pass, so positive review.

New commits:

​778b876removing TAB again
​316ab9bMerge branch 't/23671/hypergeometric_motives' into t/23953/iterator_for_hypergeometric_motives

comment:7 Changed 5 years ago by git

Commit: 316ab9b04b7d917d5b64fdd1e6d6fe0c5ac2f0b6 → 949a775d11166c985cb56d03c826c6674cb7d611
Status: positive_review → needs_review

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:

​fd375d3Merge branch 'u/chapoton/23671' in 8.1.b7
​d8c961btrac 23671 care for pdf doc
​949a775Merge branch 'u/roed/iterator_for_hypergeometric_motives' of git://trac.sagemath.org/sage into t/23953/iterator_for_hypergeometric_motives

comment:8 Changed 5 years ago by David Roe

Status: needs_review → positive_review

Merged in #23671

comment:9 Changed 5 years ago by Volker Braun

Branch: u/roed/iterator_for_hypergeometric_motives → 949a775d11166c985cb56d03c826c6674cb7d611
Resolution: → fixed
Status: positive_review → closed
Note: See TracTickets for help on using tickets.