Opened 4 years ago

Closed 4 years ago

#23951 closed defect (fixed)

fix rotate and conjugate in growth diagrams

Reported by: mantepse Owned by:
Priority: major Milestone: sage-8.1
Component: combinatorics Keywords:
Cc: tscrim Merged in:
Authors: Martin Rubey Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: f958edb (Commits, GitHub, GitLab) Commit: f958edb6be7b4e12672d9f9dcc4cec5386efa2c2
Dependencies: #23319 Stopgaps:

Status badges

Description (last modified by mantepse)

The definitions of GrowthDiagram.rotate and GrowthDiagram.conjugate did not take the shape and the in-labels into account.

In the case of GrowthDiagram.rotate the in-labels must be ignored - this is what's needed in practise and there is no natural way to do anything else. But in the case of GrowthDiagram.conjugate, they must not be ignored...

Change History (9)

comment:1 Changed 4 years ago by mantepse

  • Branch set to u/mantepse/fix_rotate_and_conjugate_in_growth_diagrams

comment:2 Changed 4 years ago by mantepse

  • Authors set to Martin Rubey
  • Cc tscrim added
  • Commit set to ac55d864d5ec5dd8121a89b6771f7abbb5e46397
  • Component changed from PLEASE CHANGE to combinatorics
  • Description modified (diff)
  • Status changed from new to needs_review
  • Type changed from PLEASE CHANGE to defect

Last 10 new commits:

e248e14provide P and Q-symbol for Sylvester
984a76aSome more documentation in GrowthDiagram for interactive use.
2eca1b6improve documentation, try to balance GrowthDiagram(MyRule,...) and MyRule(...)
780b636fix wrong comment
2aa3a8dpolish
3ed851bA little bit more of doc polish.
c2ed8d3fix a parenthesis, remark on duality, fix _check_duality, add test
28ddfbeno, it's not a tree
43b6324fix typos, add reference
ac55d86fix mistakes in definition of GrowthDiagram.rotate and GrowthDiagram.conjugate

comment:3 Changed 4 years ago by mantepse

  • Dependencies set to 23319

comment:4 Changed 4 years ago by mantepse

  • Dependencies changed from 23319 to #23319

comment:5 Changed 4 years ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

LGTM.

comment:6 Changed 4 years ago by git

  • Commit changed from ac55d864d5ec5dd8121a89b6771f7abbb5e46397 to f958edb6be7b4e12672d9f9dcc4cec5386efa2c2
  • Status changed from positive_review to needs_review

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:

f958edbadd to explanatory sentences

comment:7 Changed 4 years ago by mantepse

  • Status changed from needs_review to positive_review

I pushed at the moment you set it to positive review, I'm assuming you don't mind that I make it explicit in the docstring what's done.

comment:8 Changed 4 years ago by tscrim

It is okay with me, but it is good to have me check and reset the positive review.

comment:9 Changed 4 years ago by vbraun

  • Branch changed from u/mantepse/fix_rotate_and_conjugate_in_growth_diagrams to f958edb6be7b4e12672d9f9dcc4cec5386efa2c2
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.