Opened 5 years ago

Closed 5 years ago

#23948 closed enhancement (fixed)

has_cyclotomic_factor for polynomials

Reported by: Kiran Kedlaya Owned by:
Priority: minor Milestone: sage-8.1
Component: algebra Keywords: sd91
Cc: Merged in:
Authors: Kiran Kedlaya Reviewers: Simon Brandhorst, David Roe
Report Upstream: N/A Work issues:
Branch: 14595cb (Commits, GitHub, GitLab) Commit: 14595cb384f26e422ee0aeeba2170ecfca42025a
Dependencies: Stopgaps:

Status badges

Description

This ticket adds a method has_cyclotomic_factor for polynomials, which returns True if and only if the polynomial has a nontrivial factor which is a cyclotomic polynomial (i.e., if and only if at least one root of the polynomial is a root of unity).

This is an offshoot of #23946.

Change History (23)

comment:1 Changed 5 years ago by Kiran Kedlaya

Branch: u/kedlaya/t/kedlaya/has_cyclotomic_factor

comment:2 Changed 5 years ago by git

Commit: 4cdc320de7d09e4f72c95910df97d6bd82c3f701

Branch pushed to git repo; I updated commit sha1. New commits:

f458ed6Remove unrelated patch for Laurent series
4cdc320Fix docstring formatting

comment:3 Changed 5 years ago by git

Commit: 4cdc320de7d09e4f72c95910df97d6bd82c3f70182f5d38ef872e17b40f3587697369dc4775cfaa9

Branch pushed to git repo; I updated commit sha1. New commits:

82f5d38Remove irreducible case (redundant)

comment:4 Changed 5 years ago by git

Commit: 82f5d38ef872e17b40f3587697369dc4775cfaa966293fa1e413076cd8f882fa44d0508e31752cfc

Branch pushed to git repo; I updated commit sha1. New commits:

6a4253bRemove irreducibility flag
66293faMore corrections

comment:5 Changed 5 years ago by git

Commit: 66293fa1e413076cd8f882fa44d0508e31752cfcdc1c7f1d37f6c3a7e5c2fc315220d2b3e61d9ddf

Branch pushed to git repo; I updated commit sha1. New commits:

dc1c7f1More comments in code

comment:6 Changed 5 years ago by Kiran Kedlaya

Status: newneeds_review

comment:7 Changed 5 years ago by Edgar Costa

Reviewers: Simon Brandhorst

comment:8 Changed 5 years ago by git

Commit: dc1c7f1d37f6c3a7e5c2fc315220d2b3e61d9ddfc164825109557ad45f71421abb35b952a25dbd00

Branch pushed to git repo; I updated commit sha1. New commits:

c164825Added random doctest

comment:9 Changed 5 years ago by Kiran Kedlaya

Authors: Kiran Kedlaya

comment:10 Changed 5 years ago by Simon Brandhorst

Authors: Kiran Kedlaya
Status: needs_reviewpositive_review

comment:11 Changed 5 years ago by Kiran Kedlaya

Authors: Kiran Kedlaya

comment:12 Changed 5 years ago by Kiran Kedlaya

For the record, all tests passed on k8s. (There was a failure in src/sage/repl/configuration.py which was unreproducible, so I'm treating it as spurious.)

comment:13 Changed 5 years ago by Volker Braun

Status: positive_reviewneeds_work

Merge conflict

comment:14 Changed 5 years ago by git

Commit: c164825109557ad45f71421abb35b952a25dbd00b8f9a3db6b7c3d3be4748eae5a9f0db21c4e0991

Branch pushed to git repo; I updated commit sha1. New commits:

b8f9a3dMerge branch 'develop' of git://trac.sagemath.org/sage into t/23948/has_cyclotomic_factor

comment:15 Changed 5 years ago by Kiran Kedlaya

Status: needs_workneeds_review

Weird, I didn't get a merge conflict just now. Anyway, see if this helps.

comment:16 Changed 5 years ago by David Roe

Reviewers: Simon BrandhorstSimon Brandhorst, David Roe
Status: needs_reviewpositive_review

Looks good to me.

comment:17 Changed 5 years ago by Volker Braun

Status: positive_reviewneeds_work

Merge conflict

comment:18 Changed 5 years ago by Kiran Kedlaya

Sorry, I haven't been able to reproduce the merge conflict. Would it be possible to provide more details?

comment:19 Changed 5 years ago by David Roe

Presumably it's with the next beta, so we'll need to wait until that comes out.

comment:20 Changed 5 years ago by David Roe

Branch: u/kedlaya/t/kedlaya/has_cyclotomic_factoru/roed/t/kedlaya/has_cyclotomic_factor

comment:21 Changed 5 years ago by git

Commit: b8f9a3db6b7c3d3be4748eae5a9f0db21c4e099114595cb384f26e422ee0aeeba2170ecfca42025a

Branch pushed to git repo; I updated commit sha1. New commits:

14595cbFix mistaken removal of O function in laurent_series_ring_element

comment:22 Changed 5 years ago by David Roe

Status: needs_workpositive_review

Fixed merge conflict

comment:23 Changed 5 years ago by Volker Braun

Branch: u/roed/t/kedlaya/has_cyclotomic_factor14595cb384f26e422ee0aeeba2170ecfca42025a
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.