has_cyclotomic_factor for polynomials
Reported by: 
Kiran Kedlaya 
Owned by: 

Priority:

minor

Milestone:

sage8.1

Component:

algebra

Keywords:

sd91

Cc:


Merged in:


Authors:

Kiran Kedlaya

Reviewers:

Simon Brandhorst, David Roe

Report Upstream:

N/A

Work issues:


Branch:

14595cb (Commits, GitHub, GitLab) 
Commit:

14595cb384f26e422ee0aeeba2170ecfca42025a

Dependencies:


Stopgaps:


This ticket adds a method has_cyclotomic_factor
for polynomials, which returns True if and only if the polynomial has a nontrivial factor which is a cyclotomic polynomial (i.e., if and only if at least one root of the polynomial is a root of unity).
This is an offshoot of #23946.
Change History (23)
Branch: 
→ u/kedlaya/t/kedlaya/has_cyclotomic_factor

Commit: 
→ 4cdc320de7d09e4f72c95910df97d6bd82c3f701

Commit: 
4cdc320de7d09e4f72c95910df97d6bd82c3f701 →
82f5d38ef872e17b40f3587697369dc4775cfaa9

Commit: 
82f5d38ef872e17b40f3587697369dc4775cfaa9 →
66293fa1e413076cd8f882fa44d0508e31752cfc

Commit: 
66293fa1e413076cd8f882fa44d0508e31752cfc →
dc1c7f1d37f6c3a7e5c2fc315220d2b3e61d9ddf

Status: 
new →
needs_review

Reviewers: 
→ Simon Brandhorst

Commit: 
dc1c7f1d37f6c3a7e5c2fc315220d2b3e61d9ddf →
c164825109557ad45f71421abb35b952a25dbd00

Authors: 
Kiran Kedlaya

Status: 
needs_review →
positive_review

Status: 
positive_review →
needs_work

Commit: 
c164825109557ad45f71421abb35b952a25dbd00 →
b8f9a3db6b7c3d3be4748eae5a9f0db21c4e0991

Status: 
needs_work →
needs_review

Reviewers: 
Simon Brandhorst →
Simon Brandhorst, David Roe

Status: 
needs_review →
positive_review

Status: 
positive_review →
needs_work

Branch: 
u/kedlaya/t/kedlaya/has_cyclotomic_factor →
u/roed/t/kedlaya/has_cyclotomic_factor

Commit: 
b8f9a3db6b7c3d3be4748eae5a9f0db21c4e0991 →
14595cb384f26e422ee0aeeba2170ecfca42025a

Status: 
needs_work →
positive_review

Branch: 
u/roed/t/kedlaya/has_cyclotomic_factor →
14595cb384f26e422ee0aeeba2170ecfca42025a

Resolution: 
→ fixed

Status: 
positive_review →
closed

Branch pushed to git repo; I updated commit sha1. New commits:
Remove unrelated patch for Laurent series
Fix docstring formatting