Opened 5 years ago
Closed 5 years ago
#23944 closed enhancement (fixed)
Q/Z
Reported by:  David Roe  Owned by:  

Priority:  major  Milestone:  sage8.1 
Component:  group theory  Keywords:  sd91 
Cc:  Kiran Kedlaya  Merged in:  
Authors:  David Roe, Jennifer Berg, Anthony VárillyAlvarado  Reviewers:  Kiran Kedlaya 
Report Upstream:  N/A  Work issues:  
Branch:  3dea3c3 (Commits, GitHub, GitLab)  Commit:  3dea3c3acdb99f8ecf06ea066f6a10521a8952b8 
Dependencies:  Stopgaps: 
Description
Create an abelian group representing the quotient of abelian groups Q/nZ
.
Change History (20)
comment:1 Changed 5 years ago by
Branch:  → u/roed/qmodz 

comment:2 Changed 5 years ago by
Commit:  → e6316470ea75a388c89e2f63c274c0c265d82641 

comment:3 Changed 5 years ago by
Keywords:  sd91 added 

comment:4 Changed 5 years ago by
Branch:  u/roed/qmodz → u/avarilly/qmodz 

Commit:  e6316470ea75a388c89e2f63c274c0c265d82641 → 6955600fc2baff0cf8a0fd60977cdda3ebca3ef9 
New commits:
6955600  Documented qmodnz.py and qmodnz_element.py

comment:5 Changed 5 years ago by
Branch:  u/avarilly/qmodz → u/roed/qmodz 

comment:6 Changed 5 years ago by
Authors:  David Roe → David Roe, Jennifer Berg, Anthony VárillyAlvarado 

Commit:  6955600fc2baff0cf8a0fd60977cdda3ebca3ef9 → dc34258b04d4a3060e67ccee9b50ef4fbd919287 
Status:  new → needs_review 
comment:7 Changed 5 years ago by
Commit:  dc34258b04d4a3060e67ccee9b50ef4fbd919287 → 4ad5dbdc71a29848310b1981d775945e7f1ab49f 

Branch pushed to git repo; I updated commit sha1. New commits:
4ad5dbd  Remove some blank lines

comment:8 Changed 5 years ago by
Authors:  David Roe, Jennifer Berg, Anthony VárillyAlvarado → David Roe 

I'll add Jennifer Berg and Anthony VárillyAlvarado back later; just removing them so that the patchbot will run.
comment:9 Changed 5 years ago by
Branch:  u/roed/qmodz → u/kedlaya/qmodz 

comment:10 Changed 5 years ago by
Commit:  4ad5dbdc71a29848310b1981d775945e7f1ab49f → f6f20563bbd2f8b60a6897edcc24c5b2e13a7ea9 

Branch pushed to git repo; I updated commit sha1. New commits:
f6f2056  Fix doctests for QQ

comment:11 Changed 5 years ago by
Branch:  u/kedlaya/qmodz → u/roed/qmodz 

comment:12 Changed 5 years ago by
Cc:  Kiran Kedlaya added 

Commit:  f6f20563bbd2f8b60a6897edcc24c5b2e13a7ea9 → 9a34f5b5e3f7cbe661065863335f7a8464de8aad 
comment:13 Changed 5 years ago by
Branch:  u/roed/qmodz → u/kedlaya/qmodz 

comment:14 Changed 5 years ago by
Commit:  9a34f5b5e3f7cbe661065863335f7a8464de8aad → 2340e7fb984a759fc113b47741d7aebbd913b60e 

comment:15 Changed 5 years ago by
Status:  needs_review → needs_work 

This is otherwise fine, but patchbot is reporting a bunch of doctest failures to do with categories, because QQ is now topological. We should really straighten this out.
comment:16 Changed 5 years ago by
Branch:  u/kedlaya/qmodz → u/roed/qmodz 

comment:17 Changed 5 years ago by
Commit:  2340e7fb984a759fc113b47741d7aebbd913b60e → 3dea3c3acdb99f8ecf06ea066f6a10521a8952b8 

Status:  needs_work → needs_review 
Yep. I just took out the topological axiom. All tests now pass on k8s.
New commits:
3dea3c3  32bit doctests, remove toplogical axiom from additive abelian groups, fix doctest in sage/rings/ring.pyx

comment:18 Changed 5 years ago by
Reviewers:  → Kiran Kedlaya 

Status:  needs_review → positive_review 
Good enough for me. Positive review.
comment:19 Changed 5 years ago by
Authors:  David Roe → David Roe, Jennifer Berg, Anthony VárillyAlvarado 

comment:20 Changed 5 years ago by
Branch:  u/roed/qmodz → 3dea3c3acdb99f8ecf06ea066f6a10521a8952b8 

Resolution:  → fixed 
Status:  positive_review → closed 
Branch pushed to git repo; I updated commit sha1. New commits:
Initial version of Q/Z with no documentation