Opened 5 years ago

Closed 5 years ago

#23944 closed enhancement (fixed)

Q/Z

Reported by: David Roe Owned by:
Priority: major Milestone: sage-8.1
Component: group theory Keywords: sd91
Cc: Kiran Kedlaya Merged in:
Authors: David Roe, Jennifer Berg, Anthony Várilly-Alvarado Reviewers: Kiran Kedlaya
Report Upstream: N/A Work issues:
Branch: 3dea3c3 (Commits, GitHub, GitLab) Commit: 3dea3c3acdb99f8ecf06ea066f6a10521a8952b8
Dependencies: Stopgaps:

Status badges

Description

Create an abelian group representing the quotient of abelian groups Q/nZ.

Change History (20)

comment:1 Changed 5 years ago by David Roe

Branch: u/roed/qmodz

comment:2 Changed 5 years ago by git

Commit: e6316470ea75a388c89e2f63c274c0c265d82641

Branch pushed to git repo; I updated commit sha1. New commits:

e631647Initial version of Q/Z with no documentation

comment:3 Changed 5 years ago by David Roe

Keywords: sd91 added

comment:4 Changed 5 years ago by Anthony Varilly-Alvarado

Branch: u/roed/qmodzu/avarilly/qmodz
Commit: e6316470ea75a388c89e2f63c274c0c265d826416955600fc2baff0cf8a0fd60977cdda3ebca3ef9

New commits:

6955600Documented qmodnz.py and qmodnz_element.py

comment:5 Changed 5 years ago by David Roe

Branch: u/avarilly/qmodzu/roed/qmodz

comment:6 Changed 5 years ago by David Roe

Authors: David RoeDavid Roe, Jennifer Berg, Anthony Várilly-Alvarado
Commit: 6955600fc2baff0cf8a0fd60977cdda3ebca3ef9dc34258b04d4a3060e67ccee9b50ef4fbd919287
Status: newneeds_review

New commits:

c02ff2aFixing category, adding UniqueRepresentation, tidying docstrings
b0ce12aMoving qmodz to additive_abelian
dc34258Fallout from the move to additive abelian

comment:7 Changed 5 years ago by git

Commit: dc34258b04d4a3060e67ccee9b50ef4fbd9192874ad5dbdc71a29848310b1981d775945e7f1ab49f

Branch pushed to git repo; I updated commit sha1. New commits:

4ad5dbdRemove some blank lines

comment:8 Changed 5 years ago by David Roe

Authors: David Roe, Jennifer Berg, Anthony Várilly-AlvaradoDavid Roe

I'll add Jennifer Berg and Anthony Várilly-Alvarado back later; just removing them so that the patchbot will run.

comment:9 Changed 5 years ago by Kiran Kedlaya

Branch: u/roed/qmodzu/kedlaya/qmodz

comment:10 Changed 5 years ago by git

Commit: 4ad5dbdc71a29848310b1981d775945e7f1ab49ff6f20563bbd2f8b60a6897edcc24c5b2e13a7ea9

Branch pushed to git repo; I updated commit sha1. New commits:

f6f2056Fix doctests for QQ

comment:11 Changed 5 years ago by David Roe

Branch: u/kedlaya/qmodzu/roed/qmodz

comment:12 Changed 5 years ago by Kiran Kedlaya

Cc: Kiran Kedlaya added
Commit: f6f20563bbd2f8b60a6897edcc24c5b2e13a7ea99a34f5b5e3f7cbe661065863335f7a8464de8aad

New commits:

c53f548Conversion and coercion maps
9a34f5bMerge branch 'u/kedlaya/qmodz' of git://trac.sagemath.org/sage into qmodz

comment:13 Changed 5 years ago by Kiran Kedlaya

Branch: u/roed/qmodzu/kedlaya/qmodz

comment:14 Changed 5 years ago by David Roe

Commit: 9a34f5b5e3f7cbe661065863335f7a8464de8aad2340e7fb984a759fc113b47741d7aebbd913b60e

Commenting to see new commits...


New commits:

2340e7fAdd coercion doctests, automethod for _div_

comment:15 Changed 5 years ago by Kiran Kedlaya

Status: needs_reviewneeds_work

This is otherwise fine, but patchbot is reporting a bunch of doctest failures to do with categories, because QQ is now topological. We should really straighten this out.

comment:16 Changed 5 years ago by David Roe

Branch: u/kedlaya/qmodzu/roed/qmodz

comment:17 Changed 5 years ago by David Roe

Commit: 2340e7fb984a759fc113b47741d7aebbd913b60e3dea3c3acdb99f8ecf06ea066f6a10521a8952b8
Status: needs_workneeds_review

Yep. I just took out the topological axiom. All tests now pass on k8s.


New commits:

3dea3c332-bit doctests, remove toplogical axiom from additive abelian groups, fix doctest in sage/rings/ring.pyx

comment:18 Changed 5 years ago by Kiran Kedlaya

Reviewers: Kiran Kedlaya
Status: needs_reviewpositive_review

Good enough for me. Positive review.

comment:19 Changed 5 years ago by David Roe

Authors: David RoeDavid Roe, Jennifer Berg, Anthony Várilly-Alvarado

comment:20 Changed 5 years ago by Volker Braun

Branch: u/roed/qmodz3dea3c3acdb99f8ecf06ea066f6a10521a8952b8
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.