Opened 3 years ago
Closed 3 years ago
#23944 closed enhancement (fixed)
Q/Z
Reported by:  roed  Owned by:  

Priority:  major  Milestone:  sage8.1 
Component:  group theory  Keywords:  sd91 
Cc:  kedlaya  Merged in:  
Authors:  David Roe, Jennifer Berg, Anthony VárillyAlvarado  Reviewers:  Kiran Kedlaya 
Report Upstream:  N/A  Work issues:  
Branch:  3dea3c3 (Commits)  Commit:  3dea3c3acdb99f8ecf06ea066f6a10521a8952b8 
Dependencies:  Stopgaps: 
Description
Create an abelian group representing the quotient of abelian groups Q/nZ
.
Change History (20)
comment:1 Changed 3 years ago by
 Branch set to u/roed/qmodz
comment:2 Changed 3 years ago by
 Commit set to e6316470ea75a388c89e2f63c274c0c265d82641
comment:3 Changed 3 years ago by
 Keywords sd91 added
comment:4 Changed 3 years ago by
 Branch changed from u/roed/qmodz to u/avarilly/qmodz
 Commit changed from e6316470ea75a388c89e2f63c274c0c265d82641 to 6955600fc2baff0cf8a0fd60977cdda3ebca3ef9
New commits:
6955600  Documented qmodnz.py and qmodnz_element.py

comment:5 Changed 3 years ago by
 Branch changed from u/avarilly/qmodz to u/roed/qmodz
comment:6 Changed 3 years ago by
 Commit changed from 6955600fc2baff0cf8a0fd60977cdda3ebca3ef9 to dc34258b04d4a3060e67ccee9b50ef4fbd919287
 Status changed from new to needs_review
comment:7 Changed 3 years ago by
 Commit changed from dc34258b04d4a3060e67ccee9b50ef4fbd919287 to 4ad5dbdc71a29848310b1981d775945e7f1ab49f
Branch pushed to git repo; I updated commit sha1. New commits:
4ad5dbd  Remove some blank lines

comment:8 Changed 3 years ago by
I'll add Jennifer Berg and Anthony VárillyAlvarado back later; just removing them so that the patchbot will run.
comment:9 Changed 3 years ago by
 Branch changed from u/roed/qmodz to u/kedlaya/qmodz
comment:10 Changed 3 years ago by
 Commit changed from 4ad5dbdc71a29848310b1981d775945e7f1ab49f to f6f20563bbd2f8b60a6897edcc24c5b2e13a7ea9
Branch pushed to git repo; I updated commit sha1. New commits:
f6f2056  Fix doctests for QQ

comment:11 Changed 3 years ago by
 Branch changed from u/kedlaya/qmodz to u/roed/qmodz
comment:12 Changed 3 years ago by
 Cc kedlaya added
 Commit changed from f6f20563bbd2f8b60a6897edcc24c5b2e13a7ea9 to 9a34f5b5e3f7cbe661065863335f7a8464de8aad
comment:13 Changed 3 years ago by
 Branch changed from u/roed/qmodz to u/kedlaya/qmodz
comment:14 Changed 3 years ago by
 Commit changed from 9a34f5b5e3f7cbe661065863335f7a8464de8aad to 2340e7fb984a759fc113b47741d7aebbd913b60e
comment:15 Changed 3 years ago by
 Status changed from needs_review to needs_work
This is otherwise fine, but patchbot is reporting a bunch of doctest failures to do with categories, because QQ is now topological. We should really straighten this out.
comment:16 Changed 3 years ago by
 Branch changed from u/kedlaya/qmodz to u/roed/qmodz
comment:17 Changed 3 years ago by
 Commit changed from 2340e7fb984a759fc113b47741d7aebbd913b60e to 3dea3c3acdb99f8ecf06ea066f6a10521a8952b8
 Status changed from needs_work to needs_review
Yep. I just took out the topological axiom. All tests now pass on k8s.
New commits:
3dea3c3  32bit doctests, remove toplogical axiom from additive abelian groups, fix doctest in sage/rings/ring.pyx

comment:18 Changed 3 years ago by
 Reviewers set to Kiran Kedlaya
 Status changed from needs_review to positive_review
Good enough for me. Positive review.
comment:19 Changed 3 years ago by
comment:20 Changed 3 years ago by
 Branch changed from u/roed/qmodz to 3dea3c3acdb99f8ecf06ea066f6a10521a8952b8
 Resolution set to fixed
 Status changed from positive_review to closed
Branch pushed to git repo; I updated commit sha1. New commits:
Initial version of Q/Z with no documentation