Opened 2 years ago

Closed 2 years ago

#23939 closed enhancement (fixed)

Link from IntegerVectors documentation to IntegerListsLex documentation

Reported by: ursula Owned by:
Priority: major Milestone: sage-8.1
Component: documentation Keywords: documentation, beginner, sd91
Cc: Merged in:
Authors: Sandi Rudzinski Reviewers: Rebecca Lauren Miller
Report Upstream: N/A Work issues:
Branch: 771e2e4 (Commits) Commit: 771e2e4bc3f97adf89eee1674c95ef168ed5764f
Dependencies: Stopgaps:

Description

The functionality of Integer Vectors is a subset of the functionality of the subset for Integer Lists Lex. However, the documentation for Integer Vectors at

​http://doc.sagemath.org/html/en/reference/combinat/sage/combinat/integer_vector.html

does not reference Integer Lists Lex (documented at

​http://doc.sagemath.org/html/en/reference/combinat/sage/combinat/integer_lists/invlex.html ).

Change History (12)

comment:1 Changed 2 years ago by roed

  • Component changed from PLEASE CHANGE to documentation

comment:2 Changed 2 years ago by sbrudzin

  • Branch set to u/sbrudzin/link_from_integervectors_documentation_to_integerlistslex_documentation

comment:3 Changed 2 years ago by sbrudzin

  • Commit set to 47a0009c1091ac7f47d56c9a222eb01c923bf792
  • Status changed from new to needs_review

New commits:

​47a0009Documentation changed to include an example using IntegerListsLex and a SEEALSO reference to the module.

comment:4 Changed 2 years ago by sbrudzin

  • Reviewers set to sbrudzin

comment:5 Changed 2 years ago by roed

  • Status changed from needs_review to needs_work

I think it should be 

:class:`sage.combinat.integer_lists.invlex.IntegerListsLex`

rather than 

:mod: `sage.combinat.integer_lists.invlex.IntegerListsLex`

comment:6 Changed 2 years ago by roed

Also, shouldn't sbrudzin be the author rather than the reviewer?

comment:7 Changed 2 years ago by sbrudzin

  • Authors set to sbrudzin
  • Reviewers sbrudzin deleted

comment:8 Changed 2 years ago by git

  • Commit changed from 47a0009c1091ac7f47d56c9a222eb01c923bf792 to 771e2e4bc3f97adf89eee1674c95ef168ed5764f

Branch pushed to git repo; I updated commit sha1. New commits:

​771e2e4Changed mod to class.

comment:9 Changed 2 years ago by sbrudzin

  • Status changed from needs_work to needs_review

comment:10 Changed 2 years ago by rlmiller

  • Reviewers set to Rebecca Lauren Miller
  • Status changed from needs_review to positive_review

comment:11 Changed 2 years ago by roed

  • Authors changed from sbrudzin to Sandi Rudzinski

Author should be your real name (I've fixed it).

comment:12 Changed 2 years ago by vbraun

  • Branch changed from u/sbrudzin/link_from_integervectors_documentation_to_integerlistslex_documentation to 771e2e4bc3f97adf89eee1674c95ef168ed5764f
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.