Opened 5 years ago

Closed 5 years ago

#23939 closed enhancement (fixed)

Link from IntegerVectors documentation to IntegerListsLex documentation

Reported by: Ursula Whitcher Owned by:
Priority: major Milestone: sage-8.1
Component: documentation Keywords: documentation, beginner, sd91
Cc: Merged in:
Authors: Sandi Rudzinski Reviewers: Rebecca Lauren Miller
Report Upstream: N/A Work issues:
Branch: 771e2e4 (Commits, GitHub, GitLab) Commit: 771e2e4bc3f97adf89eee1674c95ef168ed5764f
Dependencies: Stopgaps:

Status badges

Description

The functionality of Integer Vectors is a subset of the functionality of the subset for Integer Lists Lex. However, the documentation for Integer Vectors at

​http://doc.sagemath.org/html/en/reference/combinat/sage/combinat/integer_vector.html

does not reference Integer Lists Lex (documented at

​http://doc.sagemath.org/html/en/reference/combinat/sage/combinat/integer_lists/invlex.html ).

Change History (12)

comment:1 Changed 5 years ago by David Roe

Component: PLEASE CHANGE → documentation

comment:2 Changed 5 years ago by Sandi Rudzinski

Branch: → u/sbrudzin/link_from_integervectors_documentation_to_integerlistslex_documentation

comment:3 Changed 5 years ago by Sandi Rudzinski

Commit: → 47a0009c1091ac7f47d56c9a222eb01c923bf792
Status: new → needs_review

New commits:

​47a0009Documentation changed to include an example using IntegerListsLex and a SEEALSO reference to the module.

comment:4 Changed 5 years ago by Sandi Rudzinski

Reviewers: → sbrudzin

comment:5 Changed 5 years ago by David Roe

Status: needs_review → needs_work

I think it should be 

:class:`sage.combinat.integer_lists.invlex.IntegerListsLex`

rather than 

:mod: `sage.combinat.integer_lists.invlex.IntegerListsLex`

comment:6 Changed 5 years ago by David Roe

Also, shouldn't sbrudzin be the author rather than the reviewer?

comment:7 Changed 5 years ago by Sandi Rudzinski

Authors: → sbrudzin
Reviewers: sbrudzin

comment:8 Changed 5 years ago by git

Commit: 47a0009c1091ac7f47d56c9a222eb01c923bf792 → 771e2e4bc3f97adf89eee1674c95ef168ed5764f

Branch pushed to git repo; I updated commit sha1. New commits:

​771e2e4Changed mod to class.

comment:9 Changed 5 years ago by Sandi Rudzinski

Status: needs_work → needs_review

comment:10 Changed 5 years ago by Rebecca Lauren Miller

Reviewers: → Rebecca Lauren Miller
Status: needs_review → positive_review

comment:11 Changed 5 years ago by David Roe

Authors: sbrudzin → Sandi Rudzinski

Author should be your real name (I've fixed it).

comment:12 Changed 5 years ago by Volker Braun

Branch: u/sbrudzin/link_from_integervectors_documentation_to_integerlistslex_documentation → 771e2e4bc3f97adf89eee1674c95ef168ed5764f
Resolution: → fixed
Status: positive_review → closed
Note: See TracTickets for help on using tickets.