Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#23917 closed enhancement (fixed)

Deprecate element_constructor argument in Parent.__init__

Reported by: jdemeyer Owned by:
Priority: major Milestone: sage-8.1
Component: coercion Keywords:
Cc: Merged in:
Authors: Jeroen Demeyer Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: c0071e4 (Commits) Commit:
Dependencies: #23900, #23902, #23903 Stopgaps:

Description


Change History (8)

comment:1 Changed 3 years ago by jdemeyer

  • Branch set to u/jdemeyer/remove_element_constructor_argument_from_parent___init__

comment:2 Changed 3 years ago by jdemeyer

  • Commit set to a36aaa4d10ce565d99a44a28627d2faff90ad94d
  • Status changed from new to needs_review

Not tested yet, let's see what the patchbot says...

New commits:

​e6469c5Implement _element_constructor_ for Set_PythonType_class
​fe2d000Do not use element_constructor argument in CombinatorialFreeModule
​6878e67Avoid _element_constructor in padics
​33f364fDo not use element_constructor argument in padics
​cca0349Merge commit 'e6469c577cac52b360d604a18aab75fe7a60adeb'; commit 'fe2d000c882a8654c7873e67fde02e0a54a6771b'; commit '33f364fcb24b439a80abff4dbdec2e6c3152e9e8' into t/23917/remove_element_constructor_argument_from_parent___init__
​a36aaa4Remove element_constructor argument from Parent.__init__

comment:3 follow-up: Changed 3 years ago by tscrim

I think we want to deprecate the argument since Parent is included in the global namespace and is such a large building block within Sage.

comment:4 in reply to: ↑ 3 Changed 3 years ago by jdemeyer

Replying to tscrim:

I think we want to deprecate the argument since Parent is included in the global namespace and is such a large building block within Sage.

I'm afraid that you have a point, but it does mean that we won't be able to fix #23880 soon.

comment:5 Changed 3 years ago by git

  • Commit changed from a36aaa4d10ce565d99a44a28627d2faff90ad94d to c0071e40e91a4b98462985b3cd3a5be4df2a5f0d

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

​c0071e4Deprecate element_constructor argument from Parent.__init__

comment:6 Changed 3 years ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

Well, maybe we can find some way to work around the deprecation and still have #23880. Anyways, LGTM now.

comment:7 Changed 3 years ago by vbraun

  • Branch changed from u/jdemeyer/remove_element_constructor_argument_from_parent___init__ to c0071e40e91a4b98462985b3cd3a5be4df2a5f0d
  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:8 Changed 3 years ago by jdemeyer

  • Commit c0071e40e91a4b98462985b3cd3a5be4df2a5f0d deleted
  • Summary changed from Remove element_constructor argument from Parent.__init__ to Deprecate element_constructor argument in Parent.__init__
Note: See TracTickets for help on using tickets.