Opened 4 years ago

Closed 4 years ago

#23914 closed enhancement (fixed)

Various minor changes to _element_constructor

Reported by: jdemeyer Owned by:
Priority: major Milestone: sage-8.1
Component: misc Keywords:
Cc: Merged in:
Authors: Jeroen Demeyer Reviewers: Vincent Delecroix, Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 2630849 (Commits, GitHub, GitLab) Commit: 2630849a988376b44769460989a41919bbe89520
Dependencies: Stopgaps:

Status badges

Description

This collects several very minor changes regarding _element_constructor usage.

Change History (7)

comment:1 Changed 4 years ago by jdemeyer

  • Summary changed from Various changes to _element_constructor to Various minor changes to _element_constructor

comment:2 Changed 4 years ago by jdemeyer

  • Branch set to u/jdemeyer/various_changes_to__element_constructor

comment:3 Changed 4 years ago by jdemeyer

  • Commit set to 93c0dae890ad98a0b69e1abd37cdc354b06fbaaa
  • Status changed from new to needs_review

New commits:

93c0daeVarious minor changes to _element_constructor

comment:4 Changed 4 years ago by vdelecroix

typo: conditionaly -> conditionally

comment:5 Changed 4 years ago by git

  • Commit changed from 93c0dae890ad98a0b69e1abd37cdc354b06fbaaa to 2630849a988376b44769460989a41919bbe89520

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

2630849Various minor changes to _element_constructor

comment:6 Changed 4 years ago by tscrim

  • Reviewers set to Vincent Delecroix, Travis Scrimshaw
  • Status changed from needs_review to positive_review

LGTM.

comment:7 Changed 4 years ago by vbraun

  • Branch changed from u/jdemeyer/various_changes_to__element_constructor to 2630849a988376b44769460989a41919bbe89520
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.