Opened 5 years ago

Closed 5 years ago

Last modified 4 years ago

#23890 closed enhancement (fixed)

Upgrade to six 1.11

Reported by: jdemeyer Owned by:
Priority: major Milestone: sage-8.1
Component: packages: standard Keywords:
Cc: fbissey Merged in:
Authors: Jeroen Demeyer Reviewers: François Bissey
Report Upstream: N/A Work issues:
Branch: 76e5a88 (Commits, GitHub, GitLab) Commit:
Dependencies: Stopgaps:

Status badges

Change History (9)

comment:1 Changed 5 years ago by jdemeyer

  • Description modified (diff)

comment:2 Changed 5 years ago by jdemeyer

  • Branch set to u/jdemeyer/upgrade_to_six_1_11

comment:3 Changed 5 years ago by jdemeyer

  • Commit set to 76e5a88e212eee9f80099968af75270c766ab31d
  • Status changed from new to needs_review

New commits:

76e5a88Upgrade to six 1.11

comment:4 Changed 5 years ago by fbissey

  • Cc fbissey added

comment:5 Changed 5 years ago by jdemeyer

Do you have doubts about this ticket?

comment:6 Changed 5 years ago by fbissey

No it is more I am keeping an eye on some of these. For my own reasons. For this one I was hoping I was not going to have to make an ebuild for Gentoo, but it looks like I will have to.

Unlike cython, there are changes, and changes that I cannot brush off. I have already taken care of all previous sage versions in sage-on-gentoo so that they wouldn't allow the installation of this version of six.

I will give you a review in the next 24hours.

comment:7 Changed 5 years ago by fbissey

  • Reviewers set to François Bissey
  • Status changed from needs_review to positive_review

Looks good to me.

comment:8 Changed 5 years ago by vbraun

  • Branch changed from u/jdemeyer/upgrade_to_six_1_11 to 76e5a88e212eee9f80099968af75270c766ab31d
  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:9 Changed 4 years ago by embray

  • Commit 76e5a88e212eee9f80099968af75270c766ab31d deleted

I don't think you should have removed the workaround code just yet, as now this requires any downstream systems to upgrade to six 1.11. That said, I don't see any reason not to push that anyways.

Note: See TracTickets for help on using tickets.