Opened 3 years ago

Closed 3 years ago

#23866 closed enhancement (fixed)

C++ clean up in coxeter3 interface

Reported by: jdemeyer Owned by:
Priority: major Milestone: sage-8.1
Component: cython Keywords:
Cc: tscrim Merged in:
Authors: Jeroen Demeyer Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: fdea20e (Commits) Commit: fdea20e02c10943104fa979eca4346f9ede0b3fc
Dependencies: Stopgaps:

Description

Use the C++ features of Cython instead of using ccobject.h hacks.

Change History (4)

comment:1 Changed 3 years ago by jdemeyer

  • Branch set to u/jdemeyer/c___clean_up_in_coxeter3_interface

comment:2 Changed 3 years ago by jdemeyer

  • Commit set to fdea20e02c10943104fa979eca4346f9ede0b3fc
  • Status changed from new to needs_review

New commits:

fdea20eC++ clean up in coxeter3 interface

comment:3 Changed 3 years ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

Thank you for cleaning this up.

comment:4 Changed 3 years ago by vbraun

  • Branch changed from u/jdemeyer/c___clean_up_in_coxeter3_interface to fdea20e02c10943104fa979eca4346f9ede0b3fc
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.