Opened 3 years ago

Closed 3 years ago

#23861 closed defect (fixed)

Doctest: Make Expression normalization work with symbolic powers

Reported by: rws Owned by:
Priority: major Milestone: sage-8.1
Component: symbolics Keywords:
Cc: Merged in:
Authors: Ralf Stephan Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 824a54a (Commits) Commit: 824a54a09af7a8b4e82f935a884fbb10a5fbc642
Dependencies: #23950 Stopgaps:

Description (last modified by rws)

Expression normalization only works with standard polynomials: 

sage: (x^2 + x^(-2) - 2).normalize()
(x^4 - 2*x^2 + 1)/x^2

vs

sage: (x^(2*pi) + x^(-2*pi) - 2).normalize()
x^(2*pi) + x^(-2*pi) - 2

also (for different reasons):

sage: (e^2 + e^(-2) - 2).normalize()
e^2 + e^(-2) - 2

sage: (e^(2*pi) - e^(-2*pi)).normalize()
e^(2*pi) - e^(-2*pi)

This is necessary for being able to factor all symbolic expressions.

Change History (7)

comment:1 Changed 3 years ago by rws

  • Description modified (diff)

comment:2 Changed 3 years ago by rws

  • Dependencies set to pynac-0.7.12
  • Report Upstream changed from N/A to Fixed upstream, in a later stable release.

comment:3 Changed 3 years ago by rws

  • Dependencies changed from pynac-0.7.12 to #23950
  • Report Upstream changed from Fixed upstream, in a later stable release. to N/A

comment:4 Changed 3 years ago by rws

  • Branch set to u/rws/23861

comment:5 Changed 3 years ago by rws

  • Authors set to Ralf Stephan
  • Commit set to 824a54a09af7a8b4e82f935a884fbb10a5fbc642
  • Status changed from new to needs_review
  • Summary changed from Make Expression normalization work with symbolic powers to Doctest: Make Expression normalization work with symbolic powers

New commits:

​824a54a23861: Doctest fix for Expression normalization with symbolic powers

comment:6 Changed 3 years ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

LGTM.

comment:7 Changed 3 years ago by vbraun

  • Branch changed from u/rws/23861 to 824a54a09af7a8b4e82f935a884fbb10a5fbc642
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.