Opened 5 years ago
Closed 5 years ago
#23859 closed enhancement (fixed)
add plot3d example with colors
Reported by: | chapoton | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-8.1 |
Component: | graphics | Keywords: | |
Cc: | kcrisman | Merged in: | |
Authors: | Frédéric Chapoton | Reviewers: | Karl-Dieter Crisman |
Report Upstream: | N/A | Work issues: | |
Branch: | a34dba5 (Commits, GitHub, GitLab) | Commit: | a34dba5d5292541b8f88053e31da3059ef6a956b |
Dependencies: | Stopgaps: |
Description
as a partial answer to #17660
Change History (9)
comment:1 Changed 5 years ago by
- Branch set to u/chapoton/23859
- Commit set to 05eb93aaf42f5bc81d2b281431bf385017ae9230
- Status changed from new to needs_review
comment:2 Changed 5 years ago by
This is really nice. I don't know why I don't know when that was added ... can you put an interlink to where there is more documentation on the color function needing to be between 0 and 1? Otherwise as long as the patchbot is happy I think all your formatting etc. is right.
comment:3 Changed 5 years ago by
I am not sure that there is any other place where this [0,1] constraint is explained. It even does not appear in the other similar examples of plots.
comment:4 Changed 5 years ago by
I must say that I do not have much more time and energy to spend on that.
comment:5 Changed 5 years ago by
- Reviewers set to Karl-Dieter Crisman
- Status changed from needs_review to positive_review
Okay, fair enough.
comment:7 Changed 5 years ago by
- Commit changed from 05eb93aaf42f5bc81d2b281431bf385017ae9230 to a34dba5d5292541b8f88053e31da3059ef6a956b
Branch pushed to git repo; I updated commit sha1. New commits:
a34dba5 | trac 23859 fixing doctest
|
comment:8 Changed 5 years ago by
- Status changed from needs_work to positive_review
comment:9 Changed 5 years ago by
- Branch changed from u/chapoton/23859 to a34dba5d5292541b8f88053e31da3059ef6a956b
- Resolution set to fixed
- Status changed from positive_review to closed
New commits:
adding a nice example for plot3d with color function