Opened 3 years ago

Closed 3 years ago

#23855 closed enhancement (fixed)

Deprecate cdefs.pxi and stdsage.pxi

Reported by: jdemeyer Owned by:
Priority: major Milestone: sage-8.1
Component: cython Keywords:
Cc: Merged in:
Authors: Jeroen Demeyer Reviewers: Vincent Delecroix
Report Upstream: N/A Work issues:
Branch: 29b25b4 (Commits) Commit: 29b25b4f589ea24c2944309fffbd1c98ede0fe64
Dependencies: Stopgaps:

Description

Cython upstream considers .pxi files to be semi-deprecated, so we should deprecate cdefs.pxi and friends, which are no longer used.

Change History (8)

comment:1 Changed 3 years ago by jdemeyer

  • Summary changed from Deprecate various .pxi files to Deprecate cdefs.pxi and stdsage.pxi

comment:2 Changed 3 years ago by jdemeyer

  • Branch set to u/jdemeyer/deprecate_various__pxi_files

comment:3 Changed 3 years ago by jdemeyer

  • Commit set to 7d4891b796bc4f928fffc238a826fb47a928a3f7
  • Status changed from new to needs_review

New commits:

7d4891bDeprecate cdefs.pxi and stdsage.pxi

comment:4 Changed 3 years ago by vdelecroix

Would it be possible to doctest that the deprecation is actually visible?

comment:5 Changed 3 years ago by git

  • Commit changed from 7d4891b796bc4f928fffc238a826fb47a928a3f7 to 29b25b4f589ea24c2944309fffbd1c98ede0fe64

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

29b25b4Deprecate cdefs.pxi and stdsage.pxi

comment:6 Changed 3 years ago by jdemeyer

Done

comment:7 Changed 3 years ago by vdelecroix

  • Reviewers set to Vincent Delecroix
  • Status changed from needs_review to positive_review

Better. Thanks!

comment:8 Changed 3 years ago by vbraun

  • Branch changed from u/jdemeyer/deprecate_various__pxi_files to 29b25b4f589ea24c2944309fffbd1c98ede0fe64
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.