Opened 5 years ago

Closed 4 years ago

#23852 closed defect (fixed)

libgap is wrongly dealing with vectors

Reported by: vdelecroix Owned by:
Priority: major Milestone: sage-8.2
Component: interfaces Keywords: thursdaysbdx
Cc: Merged in:
Authors: Vincent Klein Reviewers: Vincent Delecroix
Report Upstream: N/A Work issues:
Branch: c81c325 (Commits, GitHub, GitLab) Commit: c81c325503350e6d3f1ebb4ddd7256c647f20046
Dependencies: Stopgaps:

Status badges

Description 

sage: libgap(vector((0,1,2)))
Traceback (most recent call last):
...
ValueError: libGAP: Error, Permutation: <expr> must be a positive integer (not a integer)

libgap is trying to build an object from the string representation. Since this representation is made with paranthesis, libgap tries to construct a permutation... which must be on positive integer.

We should just translate vectors into gap lists (that is what it uses for vectors).

Change History (5)

comment:1 Changed 4 years ago by vklein

  • Branch set to u/vklein/libgap_is_wrongly_dealing_with_vectors

comment:2 Changed 4 years ago by vklein

  • Authors set to Vincent Klein
  • Commit set to c81c325503350e6d3f1ebb4ddd7256c647f20046
  • Milestone changed from sage-8.1 to sage-8.2

New commits:

​c81c325Trac #23852: sage's ``Vector`` support for libgap.

comment:3 Changed 4 years ago by vklein

  • Status changed from new to needs_review

comment:4 Changed 4 years ago by vdelecroix

  • Reviewers set to Vincent Delecroix
  • Status changed from needs_review to positive_review

Good! Thanks!

comment:5 Changed 4 years ago by vbraun

  • Branch changed from u/vklein/libgap_is_wrongly_dealing_with_vectors to c81c325503350e6d3f1ebb4ddd7256c647f20046
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.