Changes between Version 3 and Version 4 of Ticket #23844


Ignore:
Timestamp:
10/09/17 04:30:42 (2 years ago)
Author:
tscrim
Comment:

LGTM (although Element does not define a __contains__, so I updated the description).

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #23844

    • Property Status changed from needs_review to positive_review
    • Property Reviewers changed from to Travis Scrimshaw
  • Ticket #23844 – Description

    v3 v4  
    1 Right now `__contains__` is just inherited from `Element` which does some very wrong stuff when both sides are `GapElement`. The following get right with the branch applied
     1Right now `__contains__` is not defined and defaults to the Python behavior, which does some very wrong stuff when both sides are `GapElement`. The following gets right with the branch applied
    22{{{
    33sage: 1 in libgap(ZZ)